updated the serializer to yield a full glyph path #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gideonthomas
suggested changes
Sep 22, 2017
| glyph = serializers.SerializerMethodField() | ||
|
|
||
| def get_glyph(self, instance): | ||
| print (settings.USE_S3) |
| from networkapi.news.models import News | ||
|
|
||
|
|
There was a problem hiding this comment.
flake8 might complain about this
| protocol='https' if request.is_secure() else 'http', | ||
| root=request.META['HTTP_HOST'], | ||
| url=settings.MEDIA_URL, | ||
| glyph=str(instance.glyph).replace(' ','%20') |
There was a problem hiding this comment.
nit: might wanna try https://docs.python.org/3.6/library/urllib.parse.html#urllib.parse.quote instead
| url=settings.MEDIA_URL, | ||
| glyph=str(instance.glyph).replace(' ','%20') | ||
| ) | ||
|
|
There was a problem hiding this comment.
i think it's 1 blank line for nested classes. But personally don't mind as long as flake8 doesn't complain
gideonthomas
approved these changes
Sep 23, 2017
gvn
added a commit
that referenced
this pull request
Sep 26, 2017
* Reactify Homepage (#768) * reactifying homepage * only fetch homepage data for homepage * fixups * guarding against null data * switching People over to XHRd React component (#778) * reactifying Upcoming (#779) * reactifying Upcoming * better name * removing unused test * updated the serializer to yield a full glyph path (#784) * updated the serializer to yield a full glyph path * add the AWS location to the absolute glyph URL (#788) * updated svg - error image (#789) * Add related model name to hompepage admin header (#772) * reactifying News (#785) * reactifying News * adding key props * removing news json injection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #769