Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide Customer Support links inside accordion #2137

Closed
kristinashu opened this issue Nov 8, 2018 · 4 comments
Closed

Hide Customer Support links inside accordion #2137

kristinashu opened this issue Nov 8, 2018 · 4 comments
Assignees
@mmmavis
Labels
buyer's guide 🛍 Issues related to the buyer's guide engineering

Comments

@kristinashu
Copy link

Add + icon where the Yes/No Face would be. Hide contact info inside. Clicking on + shows the contact info as it is now.

screen shot 2018-11-08 at 8 30 04 am
@kristinashu kristinashu added engineering buyer's guide 🛍 Issues related to the buyer's guide labels Nov 8, 2018
@mmmavis
Copy link
Collaborator

mmmavis commented Nov 14, 2018

Has the filed for "company makes it easy to contact customer support" been added to CMS yet? I can't seem to find it on the interface.

@mmmavis
Copy link
Collaborator

mmmavis commented Nov 14, 2018

Does it appear based on if any of the phone number / live chat / email / twitter fields is filled?

@kristinashu
Copy link
Author

Oh it's because on prod the copy says "Customer support" but Pomax has a PR for the copy update to go from "Customer support" to "Company makes it easy to contact customer support" #2097

Right now on prod it looks like this:
image

@kristinashu kristinashu changed the title Hide Customer Support link inside accordion Hide Customer Support links inside accordion Nov 15, 2018
@Pomax
Copy link
Contributor

Pomax commented Nov 15, 2018

(note that PR has now landed)

@mmmavis mmmavis self-assigned this Nov 16, 2018
mmmavis added a commit that referenced this issue Nov 16, 2018
@mmmavis
Related to #2137 - moved customer support to its own accordion
b3f30a2
@mmmavis mmmavis mentioned this issue Nov 16, 2018
Merged
Pomax pushed a commit that referenced this issue Nov 19, 2018
@mmmavis @Pomax
Moved customer support to its own accordion (#2214)
0e318a3 
* Related to #2137 - moved customer support to its own accordion
mmmavis added a commit that referenced this issue Nov 20, 2018
@mmmavis
Moved customer support to its own accordion (#2214)
bea522f 
* Related to #2137 - moved customer support to its own accordion
Pomax pushed a commit that referenced this issue Nov 20, 2018
@mmmavis @Pomax
Added product name to homepage & thumbnail sizing (#2232)
783f1ff 
* Related to #2229 - added product name to homepage
* Related to #2137 - moved customer support to its own accordion
* Related to #2124 - product page full width list
@dependabot-preview dependabot-preview bot mentioned this issue May 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmmavis mmmavis

Labels
buyer's guide 🛍 Issues related to the buyer's guide engineering
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Pomax @kristinashu @mmmavis