Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add product names to homepage #2229

Closed
kristinashu opened this issue Nov 19, 2018 · 0 comments
Closed

Add product names to homepage #2229

kristinashu opened this issue Nov 19, 2018 · 0 comments
Assignees
@mmmavis
Labels
buyer's guide 🛍 Issues related to the buyer's guide engineering

Comments

@kristinashu
Copy link

kristinashu commented Nov 19, 2018 •
edited
Loading

Based on design in #2191
Blocked by #2124

Note:

  • company name is .h6-heading and product name is .body but #909090
  • names are hidden on mobile

Comps: https://redpen.io/p/qz6bdb2811e058ffb1

red-pen-dfeeef57-446d-46b1-f151-13508e67836c

red-pen-4a7b925a-9a9d-43bc-efe3-85f5750f7960

image
@kristinashu kristinashu added engineering buyer's guide 🛍 Issues related to the buyer's guide labels Nov 19, 2018
@kristinashu kristinashu mentioned this issue Nov 19, 2018
Closed
@mmmavis mmmavis self-assigned this Nov 19, 2018
mmmavis added a commit that referenced this issue Nov 19, 2018
@mmmavis
Related to #2229 - added product name to homepage
d5d1cce
@mmmavis mmmavis mentioned this issue Nov 19, 2018
Merged
Pomax pushed a commit that referenced this issue Nov 20, 2018
@mmmavis @Pomax
Added product name to homepage & thumbnail sizing (#2232)
783f1ff 
* Related to #2229 - added product name to homepage
* Related to #2137 - moved customer support to its own accordion
* Related to #2124 - product page full width list
@dependabot-preview dependabot-preview bot mentioned this issue May 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmmavis mmmavis

Labels
buyer's guide 🛍 Issues related to the buyer's guide engineering
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kristinashu @mmmavis