Skip to content

Possible fix problem with ProtectedDomain....#73

Merged
casals merged 4 commits intoMovingBlocks:5.1.4from
DarkWeird:patch-1
Dec 6, 2019
Merged

Possible fix problem with ProtectedDomain....#73
casals merged 4 commits intoMovingBlocks:5.1.4from
DarkWeird:patch-1

Conversation

@DarkWeird
Copy link
Contributor

At least logging is added.

@DarkWeird
Copy link
Contributor Author

Merge below:
MovingBlocks/Terasology#3791

@casals
Copy link

casals commented Dec 6, 2019

@DarkWeird, could you please remove the commit related to the version bump? I know you did it for testing, but the extra catch should enter as a patch for 5.1.4 rather than a new minor version. Thanks!

@DarkWeird
Copy link
Contributor Author

@DarkWeird, could you please remove the commit related to the version bump? I know you did it for testing, but the extra catch should enter as a patch for 5.1.4 rather than a new minor version. Thanks!

@casals but last number for patches :(
And rewrite maven artifact - bad practices, expect snapshots

@casals
Copy link

casals commented Dec 6, 2019

@DarkWeird, could you please remove the commit related to the version bump? I know you did it for testing, but the extra catch should enter as a patch for 5.1.4 rather than a new minor version. Thanks!

@casals but last number for patches :(
And rewrite maven artifact - bad practices, expect snapshots

not necessarily - see PR #67. other than that the modifications are OK

@DarkWeird
Copy link
Contributor Author

@DarkWeird, could you please remove the commit related to the version bump? I know you did it for testing, but the extra catch should enter as a patch for 5.1.4 rather than a new minor version. Thanks!

@casals but last number for patches :(
And rewrite maven artifact - bad practices, expect snapshots

not necessarily - see PR #67. other than that the modifications are OK

Done

@casals
Copy link

casals commented Dec 6, 2019

hey, @DarkWeird - sorry - I discussed it with @Cervator and we're actually bumping the version number. could you please revert the last commit? let's keep it 5.1.5 both here and in the other PR

@casals casals merged commit 3737aed into MovingBlocks:5.1.4 Dec 6, 2019
casals added a commit that referenced this pull request Dec 6, 2019
Minor patch: bump to version 5.1.5 - see #73 for further details on PR history
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants