Merged
Conversation
Member
|
Uh oh, something went wrong with the build. Need to check on that |
Contributor
|
@DarkWeird, could you please remove the commit related to the version bump? I know you did it for testing, but the extra catch should enter as a patch for 5.1.4 rather than a new minor version. Thanks! |
Contributor
Author
|
@casals but last number for patches :( |
Member
|
Version bump is OK 👍 5.1.5 would be the next version, I'd either bump it manually while merging or rely on it already bumped, is all good :-) |
casals
approved these changes
Dec 6, 2019
Member
|
Did the Gestalt patch release real quick and merged this after testing - thanks again! :-) Also added you to the credits @DarkWeird ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains
Bump up gestalt version to 5.1.5
Merge after MovingBlocks/gestalt#73
gestalt 5.1.5 contains extended logging for getProtectedDomain error.
Must help at least invistigate : #3781
How to test
@Replicateannotation for field in Component with typecom.google.common.collect.Multimap(guava) or any collection not inherit fromjava.lang.CollectionBigInteger