Skip to content

Gestalt 5.1.5#3791

Merged
Cervator merged 2 commits intoMovingBlocks:developfrom
DarkWeird:gestalt_5.1.5
Dec 7, 2019
Merged

Gestalt 5.1.5#3791
Cervator merged 2 commits intoMovingBlocks:developfrom
DarkWeird:gestalt_5.1.5

Conversation

@DarkWeird
Copy link
Contributor

@DarkWeird DarkWeird commented Dec 5, 2019

Contains

Bump up gestalt version to 5.1.5
Merge after MovingBlocks/gestalt#73
gestalt 5.1.5 contains extended logging for getProtectedDomain error.

Must help at least invistigate : #3781

How to test

  • Make Invalid Component(With @replicate) or Event with unprocessable type in type handlers e.g:
    1. make @Replicate annotation for field in Component with type com.google.common.collect.Multimap(guava) or any collection not inherit from java.lang.Collection
    2. make any field in Event with non-java type and with non-terasology type e.g. BigInteger
  • Start serve
  • Start client
  • Connect to server
  • Make something for send network event made below
  • in log u can see "Cannot determinate Module for type: "

@GooeyHub
Copy link
Member

GooeyHub commented Dec 5, 2019

Uh oh, something went wrong with the build. Need to check on that

@casals
Copy link
Contributor

casals commented Dec 6, 2019

@DarkWeird, could you please remove the commit related to the version bump? I know you did it for testing, but the extra catch should enter as a patch for 5.1.4 rather than a new minor version. Thanks!

@DarkWeird
Copy link
Contributor Author

DarkWeird commented Dec 6, 2019

@casals but last number for patches :(
And rewrite maven artifact - bad practices, expect snapshots

@Cervator
Copy link
Member

Cervator commented Dec 6, 2019

Version bump is OK 👍 5.1.5 would be the next version, I'd either bump it manually while merging or rely on it already bumped, is all good :-)

@Cervator Cervator merged commit c8fd9d4 into MovingBlocks:develop Dec 7, 2019
@Cervator
Copy link
Member

Cervator commented Dec 7, 2019

Did the Gestalt patch release real quick and merged this after testing - thanks again! :-)

Also added you to the credits @DarkWeird !

@Cervator Cervator added this to the v2.3.0 milestone Dec 7, 2019
@Cervator Cervator added Type: Bug Issues reporting and PRs fixing problems Category: Build/CI Requests, Issues and Changes targeting gradle, groovy, Jenkins, etc. labels Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Category: Build/CI Requests, Issues and Changes targeting gradle, groovy, Jenkins, etc. Type: Bug Issues reporting and PRs fixing problems

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants