This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
Movement refactoring #803
Merged
Movement refactoring #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
after multiple stream rounds all issues have been fixed and aside from a rare case that seems to be clientsided there are no errors, going to merge but will keep an ear out for any movement bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
ports:
tgstation/tgstation#50018
tgstation/tgstation#50270
tgstation/tgstation#51348
tgstation/tgstation#52578
tgstation/tgstation#52884
tgstation/tgstation#50327
tgstation/tgstation#53374
tgstation/tgstation#52929
tgstation/tgstation#53981
tgstation/tgstation#54183
tgstation/tgstation#54078
takes blind sense from
BeeStation#8204
Should be entirely backend changes, this cleans up our movement code and moves it over to signals instead of one messy proc
Why It's Good For The Game
Turns one giant proc into a bunch of small signals should be more performant, and easier to diagnose issues with
Testing Photographs and Procedure
Screenshots&Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
add: blind sense added to blind people you can see footsteps and chat now. It needs ears to function though
/:cl: