-
-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Movement refactor #8474
Movement refactor #8474
Conversation
To note, I left most of dwasint's blindness stuff out, because Racc is already doing that in #8204 |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
DNM until #8204 (or testmerge, bacon) Mobility and status effects of this PR rely on blindness improvements of that one. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
physphoza has a while to go, some im going to kick this off the open prs for now |
Ports /tg/:
Ports:
About The Pull Request
Mostly backend fixes. Turns a lot of movement code (which was in massive procs) into signals. Code improvement and performance stuff is the primary focus here.
Mostly effects:
I also converted a bunch of overused redefines stuff into setters.
Why It's Good For The Game
Clears out a lot of code debt. Should make movement a lot more performant(which is definitely a goal if we want to transition to smooth movement eventually), and should also fix janky movement shit at higher server loads.
Code is a lot more legible, too. The whole mobility_flags thing was CBT to try and code with in a previous pr of mine, so this is a bit personal.
This PR contributes to:
Testing Photographs and Procedure
Screenshots&Videos
Flew off a two floor drop, limb disabling seems to work as expected.
Blindness performs as expected
Changelog
🆑 RKz, dwasint
refactor: basically all the limb disabling system
refactor: made a bunch of movement-related code signal-based instead of /proc/
code: carbon body position checks
code: made a bunch of overused redefines into setters
/:cl: