-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Downgraded platform_without_parent_station notice to info #1444
fix: Downgraded platform_without_parent_station notice to info #1444
Conversation
❌ Invalid acceptance test. |
… [acceptance test skip]
This change made a bunch of warning notices become info notices. We should consider having a way to ignore specific items in the comparison (e.g. anything related to platform_without_parent_station should be ignored). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
❌ Invalid acceptance test. |
This failure is expected as the PR downgrades a notice from warning to info. |
Summary:
Downgraded platform_without_parent_station notice to info.
Relocated the notice to the info section in RULES.md
Expected behavior:
If a stop has no parent station and no platform, it will issue an INFO notice instead of a WARNING.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything