Skip to content

Commit

Permalink
Merge 3134c43 into 25ed7bd
Browse files Browse the repository at this point in the history
  • Loading branch information
jcpitre authored May 24, 2023
2 parents 25ed7bd + 3134c43 commit a88eb5b
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 31 deletions.
57 changes: 29 additions & 28 deletions RULES.md
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ Each Notice is associated with a severity: `INFO`, `WARNING`, `ERROR`.
| [`non_ascii_or_non_printable_char`](#non_ascii_or_non_printable_char) | Non ascii or non printable char in `id`. |
| [`pathway_dangling_generic_node`](#pathway_dangling_generic_node) | A generic node has only one incident location in a pathway graph. |
| [`pathway_loop`](#pathway_loop) | A pathway starts and ends at the same location. |
| [`platform_without_parent_station`](#platform_without_parent_station) | A platform has no `parent_station` field set. |
| [`route_color_contrast`](#route_color_contrast) | Insufficient route color contrast. |
| [`route_long_name_contains_short_name`](#route_long_name_contains_short_name) | Long name should not contain short name for a single route. |
| [`route_short_name_too_long`](#route_short_name_too_long) | Short name of a route is too long (more than 12 characters). |
Expand All @@ -145,10 +144,12 @@ Each Notice is associated with a severity: `INFO`, `WARNING`, `ERROR`.

## Table of INFOS

| Notice code | Description |
|---------------------------------------------------|---------------------------|
| [`unknown_column`](#unknown_column) | A column name is unknown. |
| [`unknown_file`](#unknown_file) | A file is unknown. |
| Notice code | Description |
|-----------------------------------------------------------------------|-----------------------------------------------|
| [`platform_without_parent_station`](#platform_without_parent_station) | A platform has no `parent_station` field set. |
| [`unknown_column`](#unknown_column) | A column name is unknown. |
| [`unknown_file`](#unknown_file) | A file is unknown. |


<a name="SYSTEM_ERRORS"/>

Expand Down Expand Up @@ -2302,29 +2303,6 @@ A pathway should not have same values for `from_stop_id` and `to_stop_id`.
* [`pathways.txt`](http://gtfs.org/reference/static#pathwaystxt)
</details>

<a name="PlatformWithoutParentStationNotice"/>

### platform_without_parent_station

A platform has no `parent_station` field set.

#### References
* [stops.txt specification](http://gtfs.org/reference/static/#stopstxt)
<details>

#### Notice fields description
| Field name | Description | Type |
|-------------- |----------------------------------------- |--------- |
| `csvRowNumber`| Row number of the faulty record. | Long |
| `stopId` | The id of the faulty record. | String |
| `stopName` | The stop name of the faulty record. | String |
| `locationType`| The location type of the faulty record. | Integer |

#### Affected files
* [`stops.txt`](http://gtfs.org/reference/static#stopstxt)

</details>

<a name="RouteColorContrastNotice"/>

### route_color_contrast
Expand Down Expand Up @@ -2840,6 +2818,29 @@ Trips should be referred to at least once in `stop_times.txt`.

# More details - INFOS

<a name="PlatformWithoutParentStationNotice"/>

### platform_without_parent_station

A platform has no `parent_station` field set.

#### References
* [stops.txt specification](http://gtfs.org/reference/static/#stopstxt)
<details>

#### Notice fields description
| Field name | Description | Type |
|-------------- |----------------------------------------- |--------- |
| `csvRowNumber`| Row number of the faulty record. | Long |
| `stopId` | The id of the faulty record. | String |
| `stopName` | The stop name of the faulty record. | String |
| `locationType`| The location type of the faulty record. | Integer |

#### Affected files
* [`stops.txt`](http://gtfs.org/reference/static#stopstxt)

</details>

<a name="UnknownColumnNotice"/>

### unknown_column
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
package org.mobilitydata.gtfsvalidator.validator;

import static org.mobilitydata.gtfsvalidator.notice.SeverityLevel.ERROR;
import static org.mobilitydata.gtfsvalidator.notice.SeverityLevel.WARNING;
import static org.mobilitydata.gtfsvalidator.notice.SeverityLevel.INFO;

import org.mobilitydata.gtfsvalidator.annotation.GtfsValidationNotice;
import org.mobilitydata.gtfsvalidator.annotation.GtfsValidationNotice.FileRefs;
Expand Down Expand Up @@ -143,7 +143,7 @@ static class LocationWithoutParentStationNotice extends ValidationNotice {
*
* <p>This is different from `location_without_parent_station` since it is less severe.
*/
@GtfsValidationNotice(severity = WARNING, files = @FileRefs(GtfsStopSchema.class))
@GtfsValidationNotice(severity = INFO, files = @FileRefs(GtfsStopSchema.class))
static class PlatformWithoutParentStationNotice extends ValidationNotice {

/** Row number of the faulty record. */
Expand All @@ -156,7 +156,7 @@ static class PlatformWithoutParentStationNotice extends ValidationNotice {
private final String stopName;

PlatformWithoutParentStationNotice(int csvRowNumber, String stopId, String stopName) {
super(SeverityLevel.WARNING);
super(INFO);
this.csvRowNumber = csvRowNumber;
this.stopId = stopId;
this.stopName = stopName;
Expand Down

0 comments on commit a88eb5b

Please sign in to comment.