Repository navigation
Prepare Preview dependencies without selected products - #3365
Draft
karim-alweheshy wants to merge 2 commits into
Draft
karim-alweheshy wants to merge 2 commits into
karim-alweheshy wants to merge 2 commits into
Conversation
added 2 commits
September 23, 2026 20:58
Add explicit framework/import and link-input output groups for ordinary and mixed target IDs. Make metadata generation independent of expensive link artifacts and omit the selected product when preparing native Preview dependencies. Test archived frameworks and lazy output-group reachability. Signed-off-by: Karim Alweheshy <karim.alweheshy@reddit.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add dedicated output groups for preparing framework and import inputs without building the selected Bazel product. Cover ordinary and mixed-language targets, lazy materialization, and archived frameworks.
Stack
Based on #3359. Review on that prerequisite; land it first, then retarget and revalidate against
main.Validation
The diff adds output-group tests. Hosted checks reported success on the published head in the 2026-10-08 snapshot.
Testing
Run
bazel test //test/internal/files:output_files. Verify preparation does not select or rebuild the target product. No Preview Canvas rendering is claimed.