Skip to content

Concerning #163 (MusicBed) #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brachna wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Concerning #163 (MusicBed) #164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions soundscrape/soundscrape.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1098,6 +1098,12 @@ def scrape_musicbed_url(url, login, password, num_tracks=sys.maxsize, folders=Fa
puts_safe( colored.red( 'scrape_musicbed_url: couldn\'t open url: ' + each_album_url +
'. Status code: ' + str( response.status_code ) + '. Skipping.' ) )
continue
# ANNOYING redirection to profile completion page
elif ( response.url == "https://www.musicbed.com/account/complete-profile" ):
puts_safe( colored.red( 'scrape_musicbed_url: redirected to profile completion page. Aborting. ' ) +
colored.white( '\nYou should complete your profile on MusicBed site, otherwise SoundScrape can\'t find tracks.' ) )
session.close()
return []

# actually not a JSON, but a JS object, but so far so good
json = response.text.split( 'App.components.SongRows = ' )[1].split( '</script>' )[0]
Expand Down Expand Up @@ -1184,6 +1190,8 @@ def download_file(url, path, session=None, params=None):
r = session.get( url, params=params, stream=True )
elif session and not params:
r = session.get( url, stream=True )
elif not session and params:
r = requests.get( url, params=params, stream=True )
else:
r = requests.get(url, stream=True)
with open(tmp_path, 'wb') as f:
Expand Down