Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic NFTs #17

Merged
merged 13 commits into from
Mar 15, 2024
Merged

Dynamic NFTs #17

merged 13 commits into from
Mar 15, 2024

Conversation

tifrel
Copy link
Member

@tifrel tifrel commented Feb 22, 2024

  • Implements dynamic NFTs
    • Update method
    • Update event
    • Lock method
    • Lock event (part of updating minting metadata)
  • Update minting metadata event
    • Event
  • Completing event for creating new metadata (add missing fields)
  • Testing
    • Update method + event
    • Lock method + event
    • Variants of creating metadata
      • Minting cap
      • Minting expiry
      • Minters allowlist
      • Royalties
      • Dynamic NFT
  • Update minting deposit

Storage had to be reshuffled to facilitate iteration over all token IDs for a specific metadata.

Scoped out for a new task:

  • Update price method + tests (issue)
  • Update minters allowlist method + tests (issue)

This will require indexer changes. Note that metadata ID for creating metadata has been changed from u64 to U64 in case that third parties want to use JS indexers to index Mintbase.

@tifrel tifrel marked this pull request as ready for review February 26, 2024 14:03
@tifrel tifrel merged commit 67e61d5 into store-v2 Mar 15, 2024
@tifrel tifrel deleted the dynamic-nfts branch March 15, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants