Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic NFT support #479

Merged
merged 11 commits into from
Mar 7, 2024
Merged

Dynamic NFT support #479

merged 11 commits into from
Mar 7, 2024

Conversation

tifrel
Copy link
Member

@tifrel tifrel commented Feb 26, 2024 •
edited
Loading

Adds support for dynamic NFTs for as introduced here.

@tifrel tifrel changed the title Dynamic mint + update deposits Dynamic NFT support Feb 26, 2024
@tifrel tifrel marked this pull request as ready for review February 26, 2024 15:38
sainthiago
sainthiago reviewed Feb 26, 2024
View reviewed changes
packages/sdk/src/createMetadata/createMetadata.ts Outdated Show resolved Hide resolved
packages/sdk/src/lockMetadata/lockMetadata.ts Outdated Show resolved Hide resolved
packages/sdk/src/mintOnMetadata/mintOnMetadata.ts Outdated Show resolved Hide resolved
packages/sdk/src/updateMetadata/updateMetadata.ts Outdated Show resolved Hide resolved
rubenmarcus
rubenmarcus approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@rubenmarcus rubenmarcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldnt we specify the network on the methods?

@tifrel tifrel merged commit ffbd4ba into beta Mar 7, 2024
2 checks passed
@tifrel tifrel deleted the dynamic-nfts branch March 7, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sainthiago sainthiago sainthiago approved these changes

@rubenmarcus rubenmarcus rubenmarcus approved these changes

@GAllen98 GAllen98 Awaiting requested review from GAllen98 GAllen98 is a code owner

@bh2smith bh2smith Awaiting requested review from bh2smith bh2smith is a code owner

@marcelokunze marcelokunze Awaiting requested review from marcelokunze marcelokunze is a code owner

@SurgeCode SurgeCode Awaiting requested review from SurgeCode SurgeCode is a code owner

@microchipgnu microchipgnu Awaiting requested review from microchipgnu microchipgnu is a code owner

@nategeier nategeier Awaiting requested review from nategeier nategeier is a code owner

@Jxnis Jxnis Awaiting requested review from Jxnis Jxnis is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tifrel @rubenmarcus @sainthiago