Skip to content

Conversation

@kzu
Copy link
Contributor

@kzu kzu commented Sep 15, 2019

Adds documentation for dotnet/sdk#3439.

(You can replace all of this text with your description.)

Before creating your pull request, please check your content against these quality criteria:

  • Did you consider search engine optimization (SEO) when you chose the title in the metadata section and the H1 heading (i.e. the displayed title that starts with a single #)?
  • For new articles, did you add it to the table of contents?
  • Did you update the "ms.date" metadata for new or significantly updated articles?
  • Are technical terms and concepts introduced and explained, and are acronyms spelled out on first mention?
  • Should this page be linked to from other pages or Microsoft web sites?

For more information about creating content for docs.microsoft.com, see the contributor guide at https://docs.microsoft.com/contribute/.

@PRMerger13
Copy link
Contributor

@kzu : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Formatted note in Markdown.
@ShannonLeavitt ShannonLeavitt added the aq-pr-triaged tracking label for the PR review team label Sep 16, 2019
@PRMerger12
Copy link
Contributor

@ShannonLeavitt : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Mikejo5000
Copy link
Collaborator

@rainersigwald to review

Copy link
Collaborator

@Mikejo5000 Mikejo5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change requested. Thanks!

@Mikejo5000
Copy link
Collaborator

@kzu Would you commit the suggestion? Thanks!

@Mikejo5000
Copy link
Collaborator

@kzu Daniel, would you commit the suggestion? Then we can merge. Thanks!

@Mikejo5000
Copy link
Collaborator

@ghogen Gordon, would you mind committing the suggestion? I don't have permissions for that. Thanks!

@jborsecnik
Copy link
Contributor

jborsecnik commented Nov 4, 2019

@kzu, can you resolve the conflict?

@PRMerger6
Copy link
Contributor

@Mikejo5000 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Mikejo5000
Copy link
Collaborator

#sign-off

@ktoliver ktoliver merged commit c57c785 into MicrosoftDocs:master Nov 12, 2019
@bitbonk
Copy link

bitbonk commented Oct 27, 2020

Could it be that this merge commit by @Mikejo5000 accidentally removed the documentation for the InternalsVisibleTo item in in csproj files. I can't find the documentation for this anywhere.

@kzu
Copy link
Contributor Author

kzu commented Oct 29, 2020

Indeed @bitbonk , the changes tab here show no changes at all: https://github.com/MicrosoftDocs/visualstudio-docs/pull/3937/files 😕

@ktoliver
Copy link
Contributor

@Mikejo5000 It looks like resolving a merge conflict in this pull request from last year might have washed out the documentation the PR was meant to add. Could you take a look and suggest a path for fixing it, if that's what's needed? Thanks!

@ktoliver ktoliver requested a review from Mikejo5000 October 29, 2020 15:34
@Mikejo5000
Copy link
Collaborator

Hmm, yes, it looks like that's what might have happened. Added it back in MicrosoftDocs/visualstudio-docs-pr#7372

@kzu kzu deleted the patch-1 branch October 31, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.