-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add documentation for AssemblyMetadata item #3938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Documents the new behavior in dotnet/sdk#3440
|
@kzu : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
@rainersigwald for review |
|
Looks ok to me. Two concerns:
Not sure what the usual docs procedure for such a situation is . . . cc @livarcocc since Peter has moved on |
|
For these scenarios, we would need to say something like "Starting in MSBuild <version>, ...." For SDK-only information, it's critical to mention that or the doc messaging will start to get confusing. |
|
Hm... I'm not so sure that page is the right place for this doc... It starts by saying:
But these items ( So maybe what we need is an entirely new document talking about |
|
@rainersigwald for input |
|
I think having a link to SDK docs (possibly not-currently-existing, cc @mairaw) would be reasonable, but I worry about smearing things out into too many places, so I think this is a good place too. Saying items are files is flat wrong and we should just remove that sentence. |
|
@kzu Daniel, could you commit the suggestion? Then we can merge. Thanks! |
Co-Authored-By: Mike Jones <mikejo@microsoft.com>
|
@kzu : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
done @Mikejo5000 |
|
Thanks! |
|
#sign-off |
Documents the new behavior in dotnet/sdk#3440
(You can replace all of this text with your description.)
Before creating your pull request, please check your content against these quality criteria:
For more information about creating content for docs.microsoft.com, see the contributor guide at https://docs.microsoft.com/contribute/.