Skip to content

Conversation

@SzymonPobiega
Copy link

Before selecting the "Create pull request" button:

  1. Enter a meaningful title above^, using a prefix if necessary and keywords "New" or "Update" indicating the nature of changes.

  2. Describe the summary, scope, and intent of this PR:

This PR adds the messaging bridge pattern. The intent is to have this pattern listed in the category "messaging" in the pattern browser.

  1. Insert links(s) to any related work item(s) or supporting detail:

Based on https://www.enterpriseintegrationpatterns.com/patterns/messaging/MessagingBridge.html

AFTER YOUR PR HAS BEEN CREATED, expand this section for tips and additional instructions.

These are common guidelines for contributions across the repos managed by the Cloud Architecture Content Team (CACT). Some repositories may have additional specific requirements that are not listed here.

Guidance for all contributors

Topic Guidance
Draft PR If your PR will be a work-in-progress for more than a day or two, select the Convert to draft link in the upper right of the page (under Reviewers) to change it to a draft. For future reference, you can also do this using the Create pull request button drop-down during PR creation.
ms.date metadata
  • Don't update an article's "ms.date" metadata property unless you've done a full freshness review of the content. A full freshness review includes changes required to correct or improve the full technical accuracy of the article.
  • Don't update "ms.date" if you're doing targeted changes to improve non-technical aspects of the article, such as editorial quality, art improvements, article template alignment, etc.
  • If you've changed any "ms.date" properties for work that wasn't part of full review for freshness, please reset them to their previous value.
Placement and linking If you're creating a new article or articles, include updates to the related TOC.yml file to propose where the article(s) should be placed. Also consider other places within the document set where it would be beneficial to cross-reference and link to your new article(s).
PR build After you open your PR, and for each successive commit that you push to your branch, the publishing platform will run validation on the files in your pull request. A summary of the build results for each file will be inserted inline into your pull request, which includes any build suggestions/warnings/errors. PRs cannot be merged until all build errors and most warnings are resolved.
Publishing Following a successful merge, most repos publish to the live site at least once per (business) day, usually around 10am Pacific.
Additional resources

Additional guidance for private repos and internal contributors

Topic Guidance
PR size If your PR is more than ~5 lines of changes, or you'd like for the changes to go through editorial or larger review, open a contribution request at https://aka.ms/Contribution and include a link to the PR in response #8. Once it's processed, you'll be notified of the next steps.
PR title prefix Select the Edit button to the right of the PR title if you need to revise it. The following prefixes are reserved for specific contribution types:

  • [Quality Check] - maintenance work related to content quality (edit passes, art improvements, template alignment)
  • [LinkFix] - recurring/adhoc PRs to correct link URLs
  • [Pipeline] - new/updated contributor success pipeline content
  • [WIP] - a work-in-progress draft requiring several days/weeks
PR preview Following successful build of your PR, publishable files will also include Preview URL links to staged previews of your new/updated articles. Be sure to review these for verification of your intended contributions, or to send to other internal contributors for review.
PR sign-off (public repo) If an article you own is updated in a public repo PR, you are responsible for sign-off. You will be automatically notified via email. The PR will not be merged until you've had a chance to review and sign-off.
PR sign-off (private repo) After you've completed your proposed changes, addressed build warnings, and completed all review work, you can begin the sign-off process for review and merge:

  1. If your PR is in draft mode, remove "[WIP]" from the title and select Ready for review button at the bottom of the PR.
  2. Enter "#sign-off" in a new comment. This comment indicates that you're confident the work meets or exceeds Microsoft's standards for publication, and will trigger the review process.
  3. Your PR may be selected for initial review by the CACT. Following CACT review, you may receive questions or requests for additional changes. You should have initial feedback from CACT review within a few business days. If you have an urgent request or need to contact the team, please mention @MicrosoftDocs/cloud-architecture-content-team-pr-reviewers in your PR and someone will get back to you. After CACT review is complete, a CACT #sign-off will be added.
  4. Final review/merge is done by the PR review team. The PR team may also respond with feedback, categorized as "Blocking" (requires action from you), or "Non-blocking" (to be addressed in a future PR).
Additional resources

@SzymonPobiega
Copy link
Author

@microsoft-github-policy-service agree

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 51a2e4a:

✅ Validation status: passed

File Status Preview URL Details
docs/patterns/messaging-bridge-content.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
File Change Percent This PR contains file(s) with more than 30% file change.

@Court72
Copy link
Contributor

Court72 commented Jun 1, 2023

@MicrosoftDocs/cloud-architecture-content-team-pr-reviewers - Please review the proposed new article. If you want to move forward with the content, add a sign-off.

#label:"aq-pr-triaged"
#label:"pending-content-team/business-approval"
Cc: @MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added aq-pr-triaged Tracking label for the PR review team pending-content-team/business-approval Requires PnP review labels Jun 1, 2023
@BryanLa
Copy link
Contributor

BryanLa commented Jun 1, 2023

#label:"cact-review-in-progress"

@prmerger-automator prmerger-automator bot added the cact-review-in-progress Review in progress by CACT label Jun 1, 2023
@BryanLa
Copy link
Contributor

BryanLa commented Jun 1, 2023

@SzymonPobiega - thanks very much for your contribution.

We'll be reviewing this to determine next steps, which might include pulling it into our private repo so we can do additional updates and position it correctly w/our patterns content. I will drop another comment and advise once we decide on next steps..

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit abbff1e:

✅ Validation status: passed

File Status Preview URL Details
docs/patterns/messaging-bridge-content.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
File Change Percent This PR contains file(s) with more than 30% file change.

@ckittel
Copy link
Member

ckittel commented Jun 23, 2023

Any updates or next steps on this one?

@kbaley
Copy link
Contributor

kbaley commented Jul 14, 2023

Hi folks. Anything I can do to help this along for now?

@BryanLa
Copy link
Contributor

BryanLa commented Jul 14, 2023

Hi @kbaley - apologies for the delay and thanks for checking back... it's just been a busy summer for us and we have a lot of folks out of office at various times. We have this on our August sprint for resolution though, so we will have some answers in a few weeks..

Co-authored-by: Udi Dahan <udidahan@users.noreply.github.com>
@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 896a84f:

✅ Validation status: passed

File Status Preview URL Details
docs/patterns/messaging-bridge-content.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
File Change Percent This PR contains file(s) with more than 30% file change.

@ckittel
Copy link
Member

ckittel commented Aug 1, 2023

Hey there @SzymonPobiega, we would like to get this included in our architecture patterns content catalog, so thank you very much for your investment of time. We will have some suggestions coming for you soon to help align this better with what we need. We won't be able to bring this in until September, but I'll be delivering you some feedback in the next business day or so on things you can do in Aug to help us get ready to go in September. So please watch this space for next steps!

I'm moving this draft to PR status just to move it out of our normal process since it'll be open for another month or so.

@ckittel ckittel marked this pull request as draft August 1, 2023 20:25
@ckittel ckittel self-assigned this Aug 1, 2023
@ckittel ckittel self-requested a review August 1, 2023 20:25
@ckittel
Copy link
Member

ckittel commented Aug 24, 2023

@SzymonPobiega & @kbaley, hoping to do an initial pass next week. I'll let you know! Thanks for all the effort I see you've put into it so far. @udidahan, have you gotten a chance to collab yet?

Copy link
Contributor

@udidahan udidahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor wording improvements

Co-authored-by: Udi Dahan <udidahan@users.noreply.github.com>
@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit a04f0cc:

✅ Validation status: passed

File Status Preview URL Details
docs/patterns/_images/messaging-bridge-sample.png ✅Succeeded
docs/patterns/messaging-bridge-content.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
File Change Percent This PR contains file(s) with more than 30% file change.
Image File This PR added or updated an image file(s).

ckittel
ckittel previously approved these changes Aug 28, 2023
Copy link
Member

@ckittel ckittel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! Just one request on the image.

You can expect us to pick this up in September for publication. We'll leave it here/open for now, but you may see it get closed as it moves to one of our internal repos for final publication and editing.

cc: @BryanLa

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit d33de9c:

✅ Validation status: passed

File Status Preview URL Details
docs/patterns/_images/messaging-bridge-sample.png ✅Succeeded
docs/patterns/messaging-bridge-content.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
File Change Percent This PR contains file(s) with more than 30% file change.
Image File This PR added or updated an image file(s).

Copy link
Contributor

@udidahan udidahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more suggestions.

Co-authored-by: Udi Dahan <udidahan@users.noreply.github.com>
@ckittel
Copy link
Member

ckittel commented Aug 28, 2023

Thanks @udidahan, I applied those suggestions, with small tweaks to a couple.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit ed21858:

✅ Validation status: passed

File Status Preview URL Details
docs/patterns/_images/messaging-bridge-sample.png ✅Succeeded
docs/patterns/messaging-bridge-content.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
File Change Percent This PR contains file(s) with more than 30% file change.
Image File This PR added or updated an image file(s).

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 2423546:

✅ Validation status: passed

File Status Preview URL Details
docs/patterns/messaging-bridge-content.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Commits Count This PR contains more than 15 commits.
File Change Percent This PR contains file(s) with more than 30% file change.
Image File This PR added or updated an image file(s).

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit e1bdf57:

✅ Validation status: passed

File Status Preview URL Details
docs/patterns/_images/messaging-bridge-sample.png ✅Succeeded
docs/patterns/messaging-bridge-content.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Commits Count This PR contains more than 15 commits.
File Change Percent This PR contains file(s) with more than 30% file change.
Image File This PR added or updated an image file(s).

@ckittel
Copy link
Member

ckittel commented Sep 5, 2023

@SzymonPobiega, @kbaley, and @udidahan -- we are going to be closing this PR as we've opened on internally for publication (ref: MicrosoftDocs/architecture-center-pr#10955). It will still need to go through a review and editorial. We'll use this public PR (that I'm closing) for any necessary communication/updates along the way. Our goal is still to publish this month, and I don't see a reason why that shouldn't be able to happen.

So, please watch this space for updates.

#please-close

@ckittel
Copy link
Member

ckittel commented Sep 14, 2023

@SzymonPobiega, @kbaley, and @udidahan -- the content is stagged and ready for editorial. I was told that editorial has this slated for ~3 weeks from now. They are backed up with some higher priority work at the moment. I'll provide updates here as I get them.

cc: @mSarts (FYI only, no ask)

@BryanLa
Copy link
Contributor

BryanLa commented Oct 9, 2023

One more update...

Thank you to @SzymonPobiega, @kbaley, @udidahan, and @ckittel for your work on this contribution! The article will be published just as soon as the final URL is established. You'll also receive notification from our publishing team as soon as it's available.

I'll also open a PR to the previously updated Migrate your e-commerce solution to Azure article, to include a link to this new pattern article.

cc: @RobBagby

@udidahan
Copy link
Contributor

It is wonderful seeing this come to fruition.

Many thanks to everyone who helped get this done 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants