Skip to content

Conversation

@kbaley
Copy link
Contributor

@kbaley kbaley commented May 25, 2023

For "lift and shift" migrations, when refactoring to Azure Service Bus, it can reduce the risk to migrate endpoints one at a time instead of all at once. This change makes reference to the "messaging bridge" pattern as a means of accomplishing that

@prmerger-automator
Copy link
Contributor

@kbaley : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 53d1f3a:

💡 Validation status: suggestions

File Status Preview URL Details
docs/industries/retail/migrate-ecommerce-solution.md 💡Suggestion Details

docs/industries/retail/migrate-ecommerce-solution.md

  • Line 5, Column 12: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'architectures' is not a valid Microsoft alias.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@ShannonLeavitt
Copy link
Contributor

@MicrosoftDocs/cloud-architecture-content-team-pr-reviewers - Please review the proposed changes. If you want to move forward with the content, add a sign-off.

#label:"pending-content-team/business-approval"
Cc: @MicrosoftDocs/public-repo-pr-review-team

@BryanLa
Copy link
Contributor

BryanLa commented May 30, 2023

Hi @kbaley - thanks very much for your contribution. Can you also work this implementation into your addition, to cite an example: https://github.com/Microsoft/Microsoft-Message-Bridge ?

@BryanLa
Copy link
Contributor

BryanLa commented May 31, 2023

#label:"cact-review-in-progress"

@prmerger-automator prmerger-automator bot added the cact-review-in-progress Review in progress by CACT label May 31, 2023
@kbaley
Copy link
Contributor Author

kbaley commented Jun 1, 2023

@BryanLa Done. I included another example implementation of it as well.

@BryanLa
Copy link
Contributor

BryanLa commented Jun 2, 2023

@BryanLa Done. I included another example implementation of it as well.

Great, thank you @kbaley . We're planning to have a related discussion re: our patterns library in a couple of weeks, and possibly adding this as a new pattern article. We may move some of the implementation ideas to that article, and point to it from this one. Just wanted to give you a heads up that we'll probably hold off on this merge until we resolve that part.

@kbaley
Copy link
Contributor Author

kbaley commented Jun 4, 2023

@BryanLa That makes sense. I thought the same thing and have started a Message Bridge article already. If you like, I can post that up as a starting point for you. I usually find it easier to edit an existing draft than to start from scratch.

@kbaley
Copy link
Contributor Author

kbaley commented Jun 5, 2023

@BryanLa Actually, I see that a PR is already started for the new article by my colleague, Szymon.

@BryanLa
Copy link
Contributor

BryanLa commented Jun 5, 2023

@BryanLa Bryan Lamos FTE Actually, I see that a PR is already started for the new article by my colleague, Szymon.

@kbaley - yes, exactly, and I was wondering if you two knew each other as well :)

Sounds like a plan. We'll be reviewing with one of our devs in the next couple of weeks, but in the meantime, feel free to contribute to Szymon's branch. If our dev agrees we can move forward with this in our internal repo, then let you guys know when everything is set to publish.

@ckittel
Copy link
Member

ckittel commented Jun 23, 2023

Anything new to report on this, @BryanLa. Can this PR be closed?

@BryanLa
Copy link
Contributor

BryanLa commented Jun 23, 2023

@ckittel - still discussing this one and #4068. I just sent you an email update..

@BryanLa
Copy link
Contributor

BryanLa commented Aug 1, 2023

@kbaley - thanks again for your contribution and patience.

We discussed both this PR and PR 4068 today. The plan of action is to:

  • merge your contribution as-is (without citing the other/older implementations)
  • review and work with SzymonPobiega on PR 4068 over the next 2 months, to draft the messaging bridge pattern article in our patterns library
  • go back and update Migrate your e-commerce solutions to Azure and other articles, to point to the new messaging bridge pattern article

cc: @ckittel @RobBagby

@BryanLa
Copy link
Contributor

BryanLa commented Aug 1, 2023

CACT #sign-off
#remove-label:"do-not-merge"
#label:"ready-to-merge"

@Jak-MS Jak-MS merged commit db717da into MicrosoftDocs:main Aug 1, 2023
@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit abd57c3:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error: GitBranchDeletedOrForcePushed]
Cannot sync git repo to specified commit because ref +refs/pull/4058/merge has been deleted or has been force pushed.
 If this is pull request, please ensure it is mergeable (no merge conflict) and open (not closed).

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@kbaley kbaley deleted the messaging-bridge branch September 1, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants