Skip to content

Table responsiveness #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Table responsiveness #50

wants to merge 2 commits into from

Conversation

TimothyMee
Copy link

PR #47 had some issues that needed to be fixed.
This commit fixes those issues.

  • Table responsiveness has been made optional
  • The scrollback only appears when needed and not permanently visible.

- responsiveness is optional
- A scrollbar appears underneath  the table
@MicroDroid
Copy link
Owner

MicroDroid commented Jan 1, 2020

This is still a bad solution. How would the plugin user determine the table needs to be responsive or not?

Usually you just want to put data and suddenly "it works"

@TimothyMee
Copy link
Author

Exactly my thought with the previous solution, the user shouldn't have to worry about the responsiveness, it should be out of the box. But in your comment to the previous solution, you stated that the responsiveness

"should be entirely optional"

Except I misunderstood.

I thought about it and handing control of the table responsiveness to the plugin user isn't such a bad idea.

As a user, I might decide to just use bootstrap's "table-responsive" on the parent div and not want the table provided responsiveness.

@MicroDroid
Copy link
Owner

Ah no, what I meant by that rather is the scrollbar should show up or not automatically as data requires.

i.e. if the columns are too jambled that it can't fit, a scrollbar should show and the table should stop shrinking. We also need a way to handle rows with exceedingly large data somehow, or we could leave truncating up to the user?

It requires a bit of thought to get this right but I am not exactly free in the meantime to work on fixing this.

I'd appreciate any thoughts you may have.

@TimothyMee
Copy link
Author

Ohh Ok. I will look into that.

@MicroDroid MicroDroid closed this May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants