Skip to content

Make Datatable Responsive #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Make Datatable Responsive #47

wants to merge 1 commit into from

Conversation

TimothyMee
Copy link

The data-table before this commit wasn't responsive,
and when the number of columns increase or the
screen reduces, data are lost.

This commit fixes that issue,
so when the screen reduces a scrollbar is introduced,
this stops the issue of losing visuals of the data in the table.

The data-table before this commit wasn't responsive,
and when the number of columns increase or the
screen reduces, data are lost.

This commit fixes that issue,
so when the screen reduces a scrollbar is introduced,
this stops the issue of losing visuals of the data in the table.
@MicroDroid
Copy link
Owner

This PR has multiple issues:

  1. overflow-x: scroll causes the scrollbar to be permanently visible, whereas it should be auto so that the scrollbar only shows when needed.
  2. Long data (like descriptions for things) will cause the scrollbar to show even for desktop screens
  3. This should be entirely optional.

@cssailing
Copy link

when you are view table on mobile, you can choose to 'scroll', use the table swipe from right or to left,
or you can make the table tr { display: inline-block;}
or you can make table tr{display: none;} to hidden tr, and make td data-lable show as td's title, and the table swipe up and down

@MicroDroid
Copy link
Owner

@cssailing That doesn't make sense.

@MicroDroid MicroDroid closed this Dec 2, 2019
@TimothyMee TimothyMee mentioned this pull request Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants