Skip to content

Conversation

@Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Jul 24, 2023

This synchronises this package with the module template for July 2023. This includes:

  • ESM build.
  • Yarn constraints.
  • Updated linting rules.

This was accomplished by running template-sync, and can be validated using npx @metamask/template-sync@latest --check.

Breaking changes

  • The package can no longer be imported using filesystem-based paths, such as @metamask/rpc-errors/dist/cjs/foo.

@Mrtenz Mrtenz requested a review from a team as a code owner July 24, 2023 09:40
@socket-security
Copy link

socket-security bot commented Jul 24, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: source-map@0.7.4, clone-response@1.0.3, responselike@2.0.1, cosmiconfig@7.1.0, @mole-inc/bin-wrapper@8.0.1, @swc/cli@0.1.62, arch@2.2.0, ts-node@10.9.1, @cspotcode/source-map-support@0.8.1, @lavamoat/preinstall-always-fail@1.0.0, @tsconfig/node10@1.0.9, @tsconfig/node12@1.0.11, @tsconfig/node14@1.0.3, @tsconfig/node16@1.0.4, acorn-walk@8.2.0, builtins@5.0.1, got@11.8.6, query-ast@1.0.5, scss-parser@1.0.6, semver-compare@1.0.0, loose-envify@1.4.0, depcheck@1.4.3, readable-web-to-node-stream@3.0.2, strip-outer@2.0.0, strip-eof@1.0.0, pump@3.0.0, @tokenizer/token@0.3.0, executable@4.1.1, invariant@2.2.4, bin-check@4.1.0, semver-truncate@3.0.0, please-upgrade-node@3.2.0, sort-keys@1.1.2, lowercase-keys@2.0.0, find-versions@5.1.0, filename-reserved-regex@3.0.0, defer-to-connect@2.0.1, content-disposition@0.5.4, json-buffer@3.0.1, bin-version@6.0.0, deps-regex@0.1.4, @szmarczak/http-timer@4.0.6, @types/http-cache-semantics@4.0.1, is-binary-path@2.1.0, source-map-js@1.0.2, mime-db@1.52.0, yn@3.1.1, pseudomap@1.0.2, end-of-stream@1.4.4, semver-regex@4.0.5, binary-extensions@2.2.0, multimatch@5.0.0, ext-list@2.2.2, arg@4.1.3, require-package-name@2.0.1, chokidar@3.5.3, v8-compile-cache-lib@3.0.1, p-cancelable@2.1.1, create-require@1.1.1, array-differ@3.0.0, ieee754@1.2.1, quick-lru@5.1.1, os-filter-obj@2.0.0, sort-keys-length@1.0.1, readdirp@3.6.0, p-finally@1.0.0, arrify@2.0.1, trim-repeated@2.0.0, ext-name@5.0.0, mimic-response@1.0.1, mimic-response@3.1.0, resolve-alpn@1.2.1, http2-wrapper@1.0.3, cacheable-request@7.0.4, cacheable-lookup@5.0.4, @vue/compiler-sfc@3.3.4, eslint-plugin-n@15.7.0, sass@1.64.1

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@Mrtenz
Copy link
Member Author

Mrtenz commented Jul 24, 2023

@SocketSecurity ignore-all

Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Mrtenz Mrtenz merged commit ab0ebca into main Jul 24, 2023
@Mrtenz Mrtenz deleted the mrtenz/standardise-july-2023 branch July 24, 2023 19:39
legobeat added a commit to legobeat/rpc-errors that referenced this pull request Aug 23, 2023
…k#98)"

This reverts commit ab0ebca.

As MetaMask#98 removes the ability to import or require from paths like
 `@metamask/rpc-errors/dist/foo` and a release is still pending for the
 current major, this will have to be temporarily reverted.
legobeat added a commit that referenced this pull request Aug 23, 2023
…103)

This reverts commit ab0ebca.

As #98 removes the ability to import or require from paths like
 `@metamask/rpc-errors/dist/foo` and a release is still pending for the
 current major, this will have to be temporarily reverted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants