Skip to content

devDeps: @metamask/eslint-config* from v11 to v12 #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 17, 2023
Merged

devDeps: @metamask/eslint-config* from v11 to v12 #110

merged 8 commits into from
Oct 17, 2023

Conversation

@legobeat
Copy link
Contributor

@legobeat legobeat commented Aug 31, 2023

Was previously also part of #98

@socket-security
Copy link

socket-security bot commented Aug 31, 2023 •
edited
Loading

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@types/node 16.18.58 None +0 3.52 MB types
eslint-plugin-n 15.7.0 filesystem +4 883 kB weiran.zsd
@metamask/eslint-config-jest 11.1.0...12.1.0 None +1/-2 3.53 MB metamaskbot
@metamask/eslint-config-typescript 11.1.0...12.1.0 None +1/-2 40.1 MB metamaskbot
@metamask/eslint-config-nodejs 11.1.0...12.1.0 None +5/-3 978 kB metamaskbot

🚮 Removed packages: @metamask/eslint-config@11.1.0, eslint-plugin-node@11.1.0

@socket-security
Copy link

socket-security bot commented Aug 31, 2023 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@legobeat legobeat force-pushed the devDeps-eslint-config-12 branch from 3c29d01 to d227578 Compare August 31, 2023 22:22
@legobeat
Copy link
Contributor Author

legobeat commented Aug 31, 2023 

@SocketSecurity ignore builtins@5.0.1
@SocketSecurity ignore eslint-plugin-n@15.7.0

@legobeat legobeat added the dependencies Pull requests that update a dependency file label Aug 31, 2023
@legobeat legobeat marked this pull request as ready for review August 31, 2023 22:27
@legobeat legobeat requested a review from a team as a code owner August 31, 2023 22:27
@legobeat legobeat force-pushed the devDeps-eslint-config-12 branch 2 times, most recently from 5a4c6c3 to efb533e Compare September 1, 2023 00:46
mcmire
mcmire previously approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@legobeat legobeat force-pushed the devDeps-eslint-config-12 branch 2 times, most recently from e0b0c15 to edabb3a Compare October 7, 2023 02:58
@legobeat legobeat requested a review from mcmire October 7, 2023 03:02
Mrtenz
Mrtenz previously approved these changes Oct 7, 2023
View reviewed changes
@legobeat legobeat force-pushed the devDeps-eslint-config-12 branch 2 times, most recently from 00b32d1 to ee8f785 Compare October 10, 2023 00:36
@legobeat legobeat requested a review from Mrtenz October 10, 2023 00:36
Mrtenz
Mrtenz previously approved these changes Oct 10, 2023
View reviewed changes
@legobeat legobeat force-pushed the devDeps-eslint-config-12 branch from ee8f785 to 86a1bc2 Compare October 10, 2023 10:49
@legobeat legobeat requested a review from a team October 10, 2023 10:50
Mrtenz
Mrtenz reviewed Oct 10, 2023
View reviewed changes
Mrtenz
Mrtenz previously approved these changes Oct 10, 2023
View reviewed changes
@legobeat legobeat requested review from a team and Mrtenz October 13, 2023 07:00
@legobeat legobeat merged commit 9632f91 into MetaMask:main Oct 17, 2023
@legobeat legobeat deleted the devDeps-eslint-config-12 branch October 17, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mrtenz Mrtenz Mrtenz approved these changes

@mcmire mcmire Awaiting requested review from mcmire

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@legobeat @mcmire @Mrtenz