Skip to content

chore: Update @metamask/signature-controller #20202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gudahtt merged 2 commits into from
Oct 21, 2025
Merged

chore: Update @metamask/signature-controller #20202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
088e220
Add @MetaMask/delegation to codeowners for delegation specific code
jeffsmale90 Sep 22, 2025
657705e
Update @metamask/signature-controller
jeffsmale90 Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,9 @@ app/components/Views/Onboarding @MetaMask/web3auth
app/reducers/onboarding @MetaMask/web3auth

# Delegation team
app/core/Engine/controllers/gator-permissions-controller @MetaMask/delegation
app/core/Engine/messengers/gator-permissions-controller-messenger @MetaMask/delegation
app/core/Engine/controllers/gator-permissions-controller @MetaMask/delegation
app/core/Engine/messengers/gator-permissions-controller-messenger @MetaMask/delegation

# QA Team - E2E Framework
e2e/api-mocking/ @MetaMask/qa
e2e/fixtures/ @MetaMask/qa
Expand Down
5 changes: 4 additions & 1 deletion app/core/Engine/messengers/signature-controller-messenger/signature-controller-messenger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {
import { NetworkControllerGetNetworkClientByIdAction } from '@metamask/network-controller';

import type { SignatureControllerMessenger } from '@metamask/signature-controller';
import { GatorPermissionsControllerDecodePermissionFromPermissionContextForOriginAction } from '@metamask/gator-permissions-controller';

type MessengerActions =
| AccountsControllerGetStateAction
Expand All @@ -18,7 +19,8 @@ type MessengerActions =
| NetworkControllerGetNetworkClientByIdAction
| KeyringControllerSignMessageAction
| KeyringControllerSignPersonalMessageAction
| KeyringControllerSignTypedMessageAction;
| KeyringControllerSignTypedMessageAction
| GatorPermissionsControllerDecodePermissionFromPermissionContextForOriginAction;

type MessengerEvents = never;

Expand All @@ -35,6 +37,7 @@ export function getSignatureControllerMessenger(
'KeyringController:signMessage',
'KeyringController:signPersonalMessage',
'KeyringController:signTypedMessage',
'GatorPermissionsController:decodePermissionFromPermissionContextForOrigin',
],
allowedEvents: [],
});
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@
"@metamask/sdk-communication-layer": "0.33.1",
"@metamask/seedless-onboarding-controller": "^4.0.0",
"@metamask/selected-network-controller": "^24.0.0",
"@metamask/signature-controller": "^33.0.0",
"@metamask/signature-controller": "^34.0.0",
"@metamask/slip44": "^4.2.0",
"@metamask/smart-transactions-controller": "^19.2.1",
"@metamask/snaps-controllers": "^15.0.2",
Expand Down
17 changes: 9 additions & 8 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8487,24 +8487,25 @@ __metadata:
languageName: node
linkType: hard

"@metamask/signature-controller@npm:^33.0.0":
version: 33.0.0
resolution: "@metamask/signature-controller@npm:33.0.0"
"@metamask/signature-controller@npm:^34.0.0":
version: 34.0.1
resolution: "@metamask/signature-controller@npm:34.0.1"
dependencies:
"@metamask/base-controller": "npm:^8.1.0"
"@metamask/controller-utils": "npm:^11.12.0"
"@metamask/base-controller": "npm:^8.4.1"
"@metamask/controller-utils": "npm:^11.14.1"
"@metamask/eth-sig-util": "npm:^8.2.0"
"@metamask/utils": "npm:^11.4.2"
"@metamask/utils": "npm:^11.8.1"
jsonschema: "npm:^1.4.1"
lodash: "npm:^4.17.21"
uuid: "npm:^8.3.2"
peerDependencies:
"@metamask/accounts-controller": ^33.0.0
"@metamask/approval-controller": ^7.0.0
"@metamask/gator-permissions-controller": ^0.2.0
"@metamask/keyring-controller": ^23.0.0
"@metamask/logging-controller": ^6.0.0
"@metamask/network-controller": ^24.0.0
checksum: 10/9fb0c33fd14dba0d7389fbe581c6cdd8f92870aaaebe92fc610e16b591572bea025760d5dbd87d35a3c4408936fb08cc163623d6f22bfbd36f3921178f8688e5
checksum: 10/ea6df5afeb99f5859ab7ab3cc50cf67827b87907932e429dbff37f65818a58a139348aab9c7b0870e0d68f2ca1b5763afa1677722e50bf5179923b6dd6573f9a
languageName: node
linkType: hard

Expand Down Expand Up @@ -34164,7 +34165,7 @@ __metadata:
"@metamask/sdk-communication-layer": "npm:0.33.1"
"@metamask/seedless-onboarding-controller": "npm:^4.0.0"
"@metamask/selected-network-controller": "npm:^24.0.0"
"@metamask/signature-controller": "npm:^33.0.0"
"@metamask/signature-controller": "npm:^34.0.0"
"@metamask/slip44": "npm:^4.2.0"
"@metamask/smart-transactions-controller": "npm:^19.2.1"
"@metamask/snaps-controllers": "npm:^15.0.2"
Expand Down
Loading