Skip to content

Conversation

@jeffsmale90
Copy link
Contributor

@jeffsmale90 jeffsmale90 commented Sep 22, 2025

Description

Updates the dependency on @metamask/signature-controller to 34.0.0

This version bump introduces a dependency on @metamask/gator-permissions-controller via GatorPermissionsControllerDecodePermissionFromPermissionContextForOriginAction which has been added to signature-controller-messenger.

Changelog

From SignatureController https://github.com/MetaMask/core/blob/main/packages/signature-controller/CHANGELOG.md:

@metamask/signature-controller 34.0.0

Added

Changed

@metamask/signature-controller 33.0.0

Changed

CHANGELOG entry: null

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Upgrade @metamask/signature-controller to ^34 and allow GatorPermissionsController decode action in the signature controller messenger.

  • Dependencies:
    • Bump @metamask/signature-controller to ^34.0.0.
  • Engine:
    • app/core/Engine/messengers/signature-controller-messenger/signature-controller-messenger.ts:
      • Add GatorPermissionsControllerDecodePermissionFromPermissionContextForOriginAction and allow GatorPermissionsController:decodePermissionFromPermissionContextForOrigin in allowedActions.

Written by Cursor Bugbot for commit 657705e. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added team-delegation MetaMask Delegation Team INVALID-PR-TEMPLATE PR's body doesn't match template labels Sep 22, 2025
Base automatically changed from feat/integrate-gator-permissions-controller to main September 22, 2025 22:42
@atlassian
Copy link

atlassian bot commented Sep 22, 2025

🔗 Link your GitHub account to Atlassian

To enable Code Reviewer, please link your GitHub account to your Atlassian account.

Click here to connect your accounts

This is a one-time setup that takes less than a minute.

@jeffsmale90 jeffsmale90 force-pushed the chore/upgrade_signatureController_34.0.0 branch from b2758bc to da70619 Compare October 21, 2025 03:55
@github-actions github-actions bot added size-S and removed size-XS labels Oct 21, 2025
@socket-security
Copy link

socket-security bot commented Oct 21, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​signature-controller@​33.0.0 ⏵ 34.0.199 +210078 +296 -1100

View full report

@jeffsmale90 jeffsmale90 changed the title Update @metamask/signature-controller chore: Update @metamask/signature-controller Oct 21, 2025
@jeffsmale90 jeffsmale90 marked this pull request as ready for review October 21, 2025 03:58
@jeffsmale90 jeffsmale90 requested a review from a team as a code owner October 21, 2025 03:58
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.23%. Comparing base (d68cc52) to head (da70619).
⚠️ Report is 32 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20202      +/-   ##
==========================================
+ Coverage   77.11%   77.23%   +0.12%     
==========================================
  Files        3615     3641      +26     
  Lines       89144    89510     +366     
  Branches    16861    16950      +89     
==========================================
+ Hits        68745    69137     +392     
+ Misses      15721    15700      -21     
+ Partials     4678     4673       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

OGPoyraz
OGPoyraz previously approved these changes Oct 21, 2025
- adds allowed method 'GatorPermissionsController:decodePermissionFromPermissionContextForOrigin' to the SignatureControllerMessenger
@Gudahtt Gudahtt force-pushed the chore/upgrade_signatureController_34.0.0 branch from da70619 to 657705e Compare October 21, 2025 18:14
@Gudahtt
Copy link
Member

Gudahtt commented Oct 21, 2025

Rebased to resolve conflicts in yarn.lock

@sonarqubecloud
Copy link

@Gudahtt Gudahtt enabled auto-merge October 21, 2025 18:58
@Gudahtt Gudahtt added this pull request to the merge queue Oct 21, 2025
auto-merge was automatically disabled October 21, 2025 20:27

Pull Request is not mergeable

Merged via the queue into main with commit 97ba5d6 Oct 21, 2025
145 of 148 checks passed
@Gudahtt Gudahtt deleted the chore/upgrade_signatureController_34.0.0 branch October 21, 2025 20:35
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2025
@metamaskbot metamaskbot added the release-7.59.0 Issue or pull request that will be included in release 7.59.0 label Oct 21, 2025
@metamaskbot metamaskbot added release-7.58.0 Issue or pull request that will be included in release 7.58.0 and removed release-7.59.0 Issue or pull request that will be included in release 7.59.0 labels Oct 22, 2025
@metamaskbot
Copy link
Collaborator

Missing release label release-7.58.0 on PR. Adding release label release-7.58.0 on PR and removing other release labels(release-7.59.0), as PR was added to branch 7.58.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-7.58.0 Issue or pull request that will be included in release 7.58.0 size-S team-delegation MetaMask Delegation Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants