-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore: Update @metamask/signature-controller #20202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔗 Link your GitHub account to AtlassianTo enable Code Reviewer, please link your GitHub account to your Atlassian account. Click here to connect your accounts This is a one-time setup that takes less than a minute. |
b2758bc to
da70619
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20202 +/- ##
==========================================
+ Coverage 77.11% 77.23% +0.12%
==========================================
Files 3615 3641 +26
Lines 89144 89510 +366
Branches 16861 16950 +89
==========================================
+ Hits 68745 69137 +392
+ Misses 15721 15700 -21
+ Partials 4678 4673 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- adds allowed method 'GatorPermissionsController:decodePermissionFromPermissionContextForOrigin' to the SignatureControllerMessenger
da70619 to
657705e
Compare
|
Rebased to resolve conflicts in |
|
Pull Request is not mergeable
|
Missing release label release-7.58.0 on PR. Adding release label release-7.58.0 on PR and removing other release labels(release-7.59.0), as PR was added to branch 7.58.0 when release was cut. |



Description
Updates the dependency on @metamask/signature-controller to 34.0.0
This version bump introduces a dependency on @metamask/gator-permissions-controller via
GatorPermissionsControllerDecodePermissionFromPermissionContextForOriginActionwhich has been added to signature-controller-messenger.Changelog
From SignatureController https://github.com/MetaMask/core/blob/main/packages/signature-controller/CHANGELOG.md:
@metamask/signature-controller 34.0.0
Added
@metamask/gator-permissions-controllerwhen callingnewUnsignedTypedMessage(#6619)Changed
@metamask/signature-controller 33.0.0
Changed
CHANGELOG entry: null
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Upgrade @metamask/signature-controller to ^34 and allow GatorPermissionsController decode action in the signature controller messenger.
@metamask/signature-controllerto^34.0.0.app/core/Engine/messengers/signature-controller-messenger/signature-controller-messenger.ts:GatorPermissionsControllerDecodePermissionFromPermissionContextForOriginActionand allowGatorPermissionsController:decodePermissionFromPermissionContextForOrigininallowedActions.Written by Cursor Bugbot for commit 657705e. This will update automatically on new commits. Configure here.