Skip to content

Conversation

@ieow
Copy link
Contributor

@ieow ieow commented Jul 18, 2025

Description

  • Handle SRP and private key sync in social login flow
  • check password outdated before import SRP/private key
  • sync SRP/private key to metadata store when import
  • sync multi SRP/private key to account when show SRP list

Changelog

CHANGELOG entry: Sync SRP from social account metadata store when open SRP list

Related issues

Fixes:
#17537
#17318

Manual testing steps

Rehydrate with all SRP/Private Key

  1. Log in social account on a device (extension/mobile)
  2. Add multiple SRP, Private Key to the account
  3. On another mobile device, login to same account
  4. All SRP, Private Key should be synced

Sync SRP/Private Key in logged in device

  1. Login social account on a device (extension/mobile)
  2. Login same account on another mobile device
  3. Add new SRP/Private Key to the account
  4. new SRP/Private Key should be synced to the first device
  5. on the first device, add new SRP/Private Key
  6. new SRP/Private Key should be synced to second mobile device

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tuna1207 tuna1207 added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed Run Smoke E2E labels Jul 24, 2025
@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3003fcf
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4b9ae024-c234-4696-8cfe-6591c80d57e5

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@chaitanyapotti chaitanyapotti enabled auto-merge July 24, 2025 14:31
Copy link
Contributor

@himanshuchawla009 himanshuchawla009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti added this pull request to the merge queue Jul 24, 2025
Merged via the queue into main with commit 0a558f3 Jul 24, 2025
64 of 75 checks passed
@chaitanyapotti chaitanyapotti deleted the feat/seedless-keys-sync branch July 24, 2025 14:53
@github-actions github-actions bot removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jul 24, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2025
@metamaskbot metamaskbot added the release-7.53.0 Issue or pull request that will be included in release 7.53.0 label Jul 24, 2025
@metamaskbot metamaskbot added release-7.52.0 Issue or pull request that will be included in release 7.52.0 and removed release-7.53.0 Issue or pull request that will be included in release 7.53.0 labels Sep 3, 2025
@metamaskbot
Copy link
Collaborator

Missing release label release-7.52.0 on PR. Adding release label release-7.52.0 on PR and removing other release labels(release-7.53.0), as PR was cherry-picked in branch 7.52.0.

1 similar comment
@metamaskbot
Copy link
Collaborator

Missing release label release-7.52.0 on PR. Adding release label release-7.52.0 on PR and removing other release labels(release-7.53.0), as PR was cherry-picked in branch 7.52.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.52.0 Issue or pull request that will be included in release 7.52.0 team-onboarding Onboarding team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants