Skip to content

Conversation

@mikesposito
Copy link
Member

Description

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@legobeat
Copy link
Contributor

legobeat commented Oct 28, 2024

@legobeat
Copy link
Contributor

@mikesposito Upgrading to v7 yields a build error for android in bitrise i am not sure what the best workaround for is. Seems like some form of incompatibility with Hermes has made its way into @metamask/rpc-errors?

#11952 (comment)

/bitrise/src/android/app/build/generated/assets/createBundleQaReleaseJsAndAssets/index.android.bundle:474144:3: error: invalid statement encountered.
  class JsonRpcError extends Error {
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/bitrise/src/android/app/build/generated/assets/createBundleQaReleaseJsAndAssets/index.android.bundle:474210:26: warning: the variable "JsonRpcError" was not declared in anonymous function " 12718#"
  exports.JsonRpcError = JsonRpcError;
                         ^~~~~~~~~~~~
/bitrise/src/android/app/build/generated/assets/createBundleQaReleaseJsAndAssets/index.android.bundle:474215:3: error: invalid statement encountered.
  class EthereumProviderError extends JsonRpcError {
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/bitrise/src/android/app/build/generated/assets/createBundleQaReleaseJsAndAssets/index.android.bundle:474231:35: warning: the variable "EthereumProviderError" was not declared in anonymous function " 12718#"
  exports.EthereumProviderError = EthereumProviderError;
                                  ^~~~~~~~~~~~~~~~~~~~~

@mikesposito
Copy link
Member Author

Addressed in #12311

@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants