Skip to content

Conversation

@mikesposito
Copy link
Member

@mikesposito mikesposito commented Oct 24, 2024

Description

This PR bumps the @metamask/selected-network-controller package to ^18.0.2

See the package changelog for details

Related issues

Related to: #11910

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@socket-security
Copy link

socket-security bot commented Oct 24, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/selected-network-controller@18.0.2 None +1 311 kB metamaskbot
npm/@metamask/signature-controller@21.1.0 network 0 287 kB metamaskbot

🚮 Removed packages: npm/@metamask/selected-network-controller@15.0.2, npm/@metamask/signature-controller@21.0.0

View full report↗︎

@mikesposito
Copy link
Member Author

Probably better to update @metamask/rpc-errors first: #12006

@mikesposito mikesposito changed the base branch from main to mikesposito/deps/rpc-errors October 24, 2024 14:21
@mikesposito mikesposito force-pushed the mikesposito/deps/selected-network-controller branch from d9fc9cf to 0a42d7e Compare October 24, 2024 14:24
@mikesposito mikesposito changed the base branch from mikesposito/deps/rpc-errors to main November 21, 2024 09:39
@mikesposito mikesposito force-pushed the mikesposito/deps/selected-network-controller branch from 0a42d7e to dc3587f Compare November 21, 2024 09:42
@socket-security
Copy link

socket-security bot commented Nov 21, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/signature-controller@21.1.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@mikesposito
Copy link
Member Author

@SocketSecurity ignore npm/@metamask/signature-controller@21.1.0

Our package

@sonarqubecloud
Copy link

@mikesposito mikesposito marked this pull request as ready for review November 21, 2024 10:26
@mikesposito mikesposito requested a review from a team as a code owner November 21, 2024 10:26
@mikesposito mikesposito requested a review from a team November 21, 2024 10:26
@mikesposito mikesposito requested a review from a team as a code owner November 21, 2024 10:26
@mikesposito mikesposito requested a review from a team November 21, 2024 10:26
@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 064593a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3bf54204-68de-4269-a302-edf637bc5f4a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@mikesposito mikesposito added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit ff51656 Nov 21, 2024
46 of 47 checks passed
@mikesposito mikesposito deleted the mikesposito/deps/selected-network-controller branch November 21, 2024 12:31
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
@metamaskbot metamaskbot added the release-7.37.0 Issue or pull request that will be included in release 7.37.0 label Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.37.0 Issue or pull request that will be included in release 7.37.0 team-wallet-framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants