-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Closed
Labels
area-transactionsdependenciesPull requests that update a dependency filePull requests that update a dependency fileteam-mobile-platformMobile Platform teamMobile Platform teamteam-transactionsTransactions teamTransactions team
Description
What is this about?
Currently used @metamask/transaction-controller@^13 uses @metamask/network-controller@^13.0.1, which uses @metamask/json-rpc-middleware@^11.0.1.
In order to align on @metamask/json-rpc-middleware@^12 and ensure compatibility, we need an upgrade to minimum @metamask/transaction-controller@^15:
Scenario
No response
Design
No response
Technical Details
$ nvs -d -p @metamask/eth-json-rpc-middleware @metamask/network-controller | grep '\^12'
$ nvs -d -p @metamask/eth-json-rpc-middleware @metamask/network-controller | grep '\^12'
15.0.0 2023-10-13T01:41:52.394Z >=16.0.0 ^12.0.0
15.1.0 2023-10-24T20:56:53.462Z >=16.0.0 ^12.0.0
15.2.0 2023-11-07T17:06:01.204Z >=16.0.0 ^12.0.1
16.0.0 2023-11-16T17:12:50.976Z >=16.0.0 ^12.0.1
17.0.0 2023-11-22T19:51:31.493Z >=16.0.0 ^12.0.1
17.1.0 2023-12-22T20:15:45.360Z >=16.0.0 ^12.0.1
17.2.0 2024-01-23T21:47:20.164Z >=16.0.0 ^12.0.1
17.2.1 2024-03-04T18:45:13.786Z >=16.0.0 ^12.1.0
18.0.0 2024-03-12T19:48:32.563Z >=16.0.0 ^12.1.0
18.0.1 2024-03-13T11:27:46.902Z >=16.0.0 ^12.1.0
18.1.0 2024-03-27T18:21:29.781Z >=16.0.0 ^12.1.0
18.1.1 2024-05-17T13:27:00.323Z >=16.0.0 ^12.1.0
18.1.2 2024-05-29T11:25:36.567Z >=16.0.0 ^12.1.1
18.1.3 2024-05-31T18:08:34.410Z >=16.0.0 ^12.1.1
19.0.0 2024-05-31T19:51:38.072Z ^18.18 || >=20 ^12.1.1
$ nvs -d -p @metamask/network-controller @metamask/transaction-controller | grep '\^1[5-9]'
$ nvs -d -p @metamask/network-controller @metamask/transaction-controller | grep '\^1[5-9]'
15.0.0 2023-10-13T01:42:28.341Z >=16.0.0 ^15.0.0
16.0.0 2023-10-24T20:57:30.469Z >=16.0.0 ^15.1.0
17.0.0 2023-11-16T17:13:13.299Z >=16.0.0 ^16.0.0
18.0.0 2023-11-22T19:52:03.144Z >=16.0.0 ^17.0.0
18.1.0 2023-11-23T16:28:03.999Z >=16.0.0 ^17.0.0
18.2.0 2023-11-29T14:34:53.287Z >=16.0.0 ^17.0.0
18.3.0 2023-11-29T21:29:16.153Z >=16.0.0 ^17.0.0
18.3.1 2023-12-19T17:19:31.119Z >=16.0.0 ^17.0.0
19.0.0 2023-12-22T20:16:15.802Z >=16.0.0 ^17.1.0
19.0.1 2024-01-04T14:55:36.428Z >=16.0.0 ^17.1.0
20.0.0 2024-01-15T14:11:12.644Z >=16.0.0 ^17.1.0
21.0.0 2024-01-23T21:47:59.994Z >=16.0.0 ^17.2.0
21.0.1 2024-01-29T17:31:48.914Z >=16.0.0 ^17.2.0
21.1.0 2024-01-31T16:46:08.407Z >=16.0.0 ^17.2.0
21.2.0 2024-02-02T22:31:36.049Z >=16.0.0 ^17.2.0
22.0.0 2024-02-15T20:55:50.514Z >=16.0.0 ^17.2.0
23.0.0 2024-02-15T23:34:52.035Z >=16.0.0 ^17.2.0
23.1.0 2024-02-26T17:08:03.928Z >=16.0.0 ^17.2.0
24.0.0 2024-03-04T18:45:39.643Z >=16.0.0 ^17.2.1
25.0.0 2024-03-12T19:49:13.478Z >=16.0.0 ^18.0.0
25.1.0 2024-03-13T11:28:46.048Z >=16.0.0 ^18.0.1
25.2.0 2024-03-20T14:54:01.563Z >=16.0.0 ^18.0.1
25.2.1 2024-03-21T09:17:39.862Z >=16.0.0 ^18.0.1
25.3.0 2024-03-25T09:38:07.544Z >=16.0.0 ^18.0.1
26.0.0 2024-03-27T18:22:17.958Z >=16.0.0 ^18.1.0
27.0.0 2024-04-02T16:10:05.147Z >=16.0.0 ^18.1.0
27.0.1 2024-04-09T15:00:29.390Z >=16.0.0 ^18.1.0
28.0.0 2024-04-15T09:48:15.418Z >=16.0.0 ^18.1.0
28.1.0 2024-04-18T15:42:27.830Z >=16.0.0 ^18.1.0
28.1.1 2024-04-30T12:11:04.564Z >=16.0.0 ^18.1.0
29.0.0 2024-05-09T15:05:56.487Z >=16.0.0 ^18.1.0
29.0.1 2024-05-17T13:27:16.946Z >=16.0.0 ^18.1.1
29.0.2 2024-05-21T17:50:10.641Z >=16.0.0 ^18.1.1
29.1.0 2024-05-21T22:27:46.309Z >=16.0.0 ^18.1.1
30.0.0 2024-05-29T11:25:50.607Z >=16.0.0 ^18.1.2
31.0.0 2024-05-31T18:09:09.121Z >=16.0.0 ^18.1.3
32.0.0 2024-05-31T19:52:16.884Z ^18.18 || >=20 ^19.0.0
Threat Modeling Framework
No response
Acceptance Criteria
No response
Stakeholder review needed before the work gets merged
- Engineering (needed in most cases)
- Design
- Product
- QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- Security
- Legal
- Marketing
- Management (please specify)
- Other (please specify)
References
Metadata
Metadata
Assignees
Labels
area-transactionsdependenciesPull requests that update a dependency filePull requests that update a dependency fileteam-mobile-platformMobile Platform teamMobile Platform teamteam-transactionsTransactions teamTransactions team