Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Solana shared utilities and constants #28269

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

ulissesferreira
Copy link
Contributor

@ulissesferreira ulissesferreira commented Nov 4, 2024

Description

As we look to simplify snaps ability to support multiple chains we find that some code needs to be included in the main extension to make sure it can be easily imported throughout. In this PR we add utility functions similar to the Bitcoin ones but for Solana.

Open in GitHub Codespaces

Manual testing steps

  1. Run tests and make sure they still pass
  2. Run build process and make sure it succeeds

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@ulissesferreira ulissesferreira requested a review from a team as a code owner November 4, 2024 14:57
Copy link
Contributor

github-actions bot commented Nov 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-sol PRs from the Solana snap team label Nov 4, 2024
@ulissesferreira ulissesferreira marked this pull request as draft November 4, 2024 14:58
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 4, 2024
@ulissesferreira
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@ulissesferreira ulissesferreira force-pushed the chore/add-solana-utilities branch 3 times, most recently from b24978d to e2b28f1 Compare November 4, 2024 15:13
@zone-live
Copy link
Contributor

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policy update failed. You can review the logs or retry the policy update here

@ulissesferreira ulissesferreira force-pushed the chore/add-solana-utilities branch 2 times, most recently from f465505 to 7f23be9 Compare November 5, 2024 13:28
@ulissesferreira ulissesferreira marked this pull request as ready for review November 5, 2024 13:31
aganglada
aganglada previously approved these changes Nov 5, 2024
Copy link

socket-security bot commented Nov 6, 2024

Copy link

socket-security bot commented Nov 6, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@ulissesferreira ulissesferreira force-pushed the chore/add-solana-utilities branch 2 times, most recently from f741ec5 to 36277ef Compare November 6, 2024 10:55
@zone-live
Copy link
Contributor

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policy update failed. You can review the logs or retry the policy update here

@ulissesferreira
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@metamaskbot metamaskbot requested a review from a team as a code owner November 6, 2024 14:06
@ulissesferreira ulissesferreira added this pull request to the merge queue Nov 6, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [aa3a372]
Page Load Metrics (2161 ± 125 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint32528622002605290
domContentLoaded182627792120260125
load186728012161261125
domInteractive19120622110
backgroundConnect1395412210
firstReactRender803001346129
getState86525199
initialActions01000
loadScripts130621581561210101
setupStore1398342411
uiStartup210531322476308148
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -2.97 KiB (-0.07%)
  • ui: -3.16 KiB (-0.04%)
  • common: 155.89 KiB (1.92%)

Merged via the queue into develop with commit 4e94984 Nov 6, 2024
76 checks passed
@ulissesferreira ulissesferreira deleted the chore/add-solana-utilities branch November 6, 2024 15:21
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-sol PRs from the Solana snap team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants