Skip to content

Commit

Permalink
chore: add Solana shared utilities and constants (#28269)
Browse files Browse the repository at this point in the history
## **Description**

As we look to simplify snaps ability to support multiple chains we find
that some code needs to be included in the main extension to make sure
it can be easily imported throughout. In this PR we add utility
functions similar to the Bitcoin ones but for Solana.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28269?quickstart=1)

## **Manual testing steps**

1. Run tests and make sure they still pass
2. Run build process and make sure it succeeds

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
  • Loading branch information
ulissesferreira and metamaskbot authored Nov 6, 2024
1 parent e5ae877 commit 4e94984
Show file tree
Hide file tree
Showing 12 changed files with 1,487 additions and 979 deletions.
13 changes: 13 additions & 0 deletions app/images/solana-logo.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions development/build/scripts.js
Original file line number Diff line number Diff line change
Expand Up @@ -935,6 +935,7 @@ function setupBundlerDefaults(
'./**/node_modules/firebase',
'./**/node_modules/@firebase',
'./**/node_modules/marked',
'./**/node_modules/@solana',
],
global: true,
},
Expand Down
Loading

0 comments on commit 4e94984

Please sign in to comment.