Commits on Oct 24, 2024

1. fix: Gas changes for low Max base fee and Priority fee (#28037) …

   <!--
   Please submit this PR as a draft initially.
   Do not mark it as "Ready for review" until the template has been
   completely filled out, and PR status checks have passed at least once.
   -->
   
   ## **Description**
   
   Previously, if the Max base fee and Priority fee were reduced to very
   low values, the Network fee wouldn't update accordingly. This is a
   discrepancy with the gas calculations in the old flows.
   
   What fixes it is, for low enough values of `maxFeePerGas` (low enough to
   be lower than `minimumFeePerGas`), the Network fee becomes the Max fee
   -- `maxFeePerGas` times `gasLimit` directly. Apart from fixing the
   symptom explained above, this ensures that the Network fee is never
   higher than the Max fee.
   
   The PR also fixes this calculation when it comes to the L2 fees (inside
   `useTransactionGasFeeEstimate`).
   
   It also adds a missing override of `dappSuggestedFees` for both
   `maxFeePerGas` and `maxPriorityFeePerGas` (inside `useEIP1559TxFees`).
   
   [![Open in GitHub
   Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28037?quickstart=1)
   
   ## **Related issues**
   
   Fixes: #27802
   
   ## **Manual testing steps**
   
   See original report above.
   
   ## **Screenshots/Recordings**
   
   <!-- If applicable, add screenshots and/or recordings to visualize the
   before and after of your change. -->
   
   ### **Before**
   
   <!-- [screenshots/recordings] -->
   
   ### **After**
   
   <!-- [screenshots/recordings] -->
   
   ## **Pre-merge author checklist**
   
   - [ ] I've followed [MetaMask Contributor
   Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
   Extension Coding
   Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
   - [ ] I've completed the PR template to the best of my ability
   - [ ] I’ve included tests if applicable
   - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
   if applicable
   - [ ] I’ve applied the right labels on the PR (see [labeling
   guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
   Not required for external contributors.
   
   ## **Pre-merge reviewer checklist**
   
   - [ ] I've manually tested the PR (e.g. pull and build branch, run the
   app, test code being changed).
   - [ ] I confirm that this PR addresses all acceptance criteria described
   in the ticket it closes and includes the necessary testing evidence such
   as recordings and or screenshots.

   

   pedronfigueiredo committed Oct 24, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 365683d
   • Browse repository at this point

   Copy the full SHA

   365683d View commit details

   Browse the repository at this point in the history