fix: cherry-pick: Gas changes for low Max base fee and Priority fee (#28037)

[pedronfigueiredo]

Cherry-pick: #28037

Description

Previously, if the Max base fee and Priority fee were reduced to very low values, the Network fee wouldn't update accordingly. This is a discrepancy with the gas calculations in the old flows.

What fixes it is, for low enough values of maxFeePerGas (low enough to be lower than minimumFeePerGas), the Network fee becomes the Max fee -- maxFeePerGas times gasLimit directly. Apart from fixing the symptom explained above, this ensures that the Network fee is never higher than the Max fee.

The PR also fixes this calculation when it comes to the L2 fees (inside useTransactionGasFeeEstimate).

It also adds a missing override of dappSuggestedFees for both maxFeePerGas and maxPriorityFeePerGas (inside useEIP1559TxFees).

Related issues

Fixes: #27802

Manual testing steps

See original report above.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding
  Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Description

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [365683d]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1764 ± 46 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1588	1967	1773	96	46
		domContentLoaded	1570	1892	1728	79	38
		load	1588	1921	1764	96	46
		domInteractive	23	197	50	38	18
		backgroundConnect	10	113	37	28	13
		firstReactRender	44	223	87	47	22
		getState	4	183	29	40	19
		initialActions	0	1	0	0	0
		loadScripts	1142	1441	1276	73	35
		setupStore	10	102	28	26	12
		uiStartup	1810	2641	1986	174	84

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 733 Bytes (0.01%)
• common: 0 Bytes (0.00%)

[metamaskbot]

No release label on PR. Adding release label release-12.6.0 on PR, as PR was cherry-picked in branch 12.6.0.