Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove obsolete preview build support #27968

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Oct 18, 2024

Description

We had previously configured CI to support installing @metamask- scoped packages from the GitHub npm registry, as we used this registry for "preview builds" from the core repository in the past. This is no longer used; we publish preview builds to npm now instead. The obsolete CI changes have been removed.

Open in GitHub Codespaces

Related issues

Manual testing steps

This is not anticipated to have any functional impact. If it does break something, it would be the install step, so we can test this by installing locally (and seeing that the install step succeeded on CI).

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot
Copy link
Collaborator

Builds ready [9886674]
Page Load Metrics (2054 ± 54 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint34023201965386186
domContentLoaded1814220520059445
load18262331205411254
domInteractive1888582211
backgroundConnect11127483417
firstReactRender5312997209
getState66221189
initialActions01000
loadScripts1304158714636632
setupStore127029199
uiStartup20242706227113464
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@Gudahtt Gudahtt marked this pull request as ready for review October 18, 2024 19:41
@Gudahtt Gudahtt requested review from kumavis and a team as code owners October 18, 2024 19:41
@Gudahtt Gudahtt added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 18, 2024
We had previously configured CI to support installing `@metamask`-
scoped packages from the GitHub npm registry, as we used this registry
for "preview builds" from the core repository in the past. This is no
longer used; we publish preview builds to npm now instead. The obsolete
CI changes have been removed.

* [Preview build instructions](https://github.com/MetaMask/core/blob/main/docs/contributing.md#testing-changes-to-packages-with-preview-builds) ([permalink](https://github.com/MetaMask/core/blob/56efd1d13a8873a5abb9bd9880d0576148b9d1e4/docs/contributing.md#testing-changes-to-packages-with-preview-builds))
* Preview build related extension PRs: #16547, #19970, #20096, #20312
@Gudahtt Gudahtt force-pushed the remove-obsolete-preview-build-support branch from 9886674 to 49446e5 Compare November 1, 2024 19:19
Copy link
Contributor

@hjetpoluru hjetpoluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@desi desi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt added this pull request to the merge queue Nov 1, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [49446e5]
Page Load Metrics (1726 ± 73 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint32221791656342164
domContentLoaded15122165169515675
load15612178172615373
domInteractive167749147
backgroundConnect96429199
firstReactRender4311085199
getState46611157
initialActions01000
loadScripts11141732126314368
setupStore1071222110
uiStartup16962335190116981
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 1, 2024
@Gudahtt Gudahtt added this pull request to the merge queue Nov 1, 2024
Merged via the queue into develop with commit db2e8be Nov 1, 2024
76 checks passed
@Gudahtt Gudahtt deleted the remove-obsolete-preview-build-support branch November 1, 2024 20:38
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 1, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-extension-platform team-wallet-framework
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants