Fix non-preview draft PR builds #20096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
fix-non-preview-draft-prs
branch
2 times, most recently
from
2e14943
to
aa16cc0
Compare
Builds ready [aa16cc0]
Page Load Metrics (1597 ± 98 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop #20096 +/- ##
===========================================
+ Coverage 68.67% 68.69% +0.02%
===========================================
Files 986 986
Lines 37874 37815 -59
Branches 10143 10116 -27
===========================================
- Hits 26009 25977 -32
+ Misses 11865 11838 -27 |
HowardBraham
added a commit
that referenced
this pull request
Jul 19, 2023
Closed
HowardBraham
added a commit
that referenced
this pull request
Jul 19, 2023
HowardBraham
added a commit
that referenced
this pull request
Jul 19, 2023
HowardBraham
added a commit
that referenced
this pull request
Jul 19, 2023
HowardBraham
added a commit
that referenced
this pull request
Jul 19, 2023
HowardBraham
added a commit
that referenced
this pull request
Jul 19, 2023
HowardBraham
added a commit
that referenced
this pull request
Jul 19, 2023
HowardBraham
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
Tested using #20103
- Updated
"@metamask/auto-changelog": "3.2.0" - Fails https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/51792/workflows/eefb779d-a8cb-41c3-bfb0-e5c0e8d16a97/jobs/1508458
- Cherry picked this PR and it succeeds https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/51793/workflows/7d8efc01-2071-4ee7-8224-be9bd1c773bd/jobs/1508459
LGTM!
Gudahtt
force-pushed
the
fix-non-preview-draft-prs
branch
from
aa16cc0
to
e275ef3
Compare
Builds ready [e275ef3]
Page Load Metrics (1671 ± 62 ms)
Bundle size diffs
|
Gudahtt
force-pushed
the
fix-non-preview-draft-prs
branch
from
e275ef3
to
9fb17b3
Compare
Builds ready [9fb17b3]
Page Load Metrics (1812 ± 57 ms)
Bundle size diffs
|
Certain draft PRs that add new dependencies have been failing because CI will try to use the GitHub npm registry, which we use for preview builds. This registry does not have non-preview package versions, so the installation will fail if new non-preview dependencies are needed. CI has been updated to only use the GitHub npm registry when preview builds are detected in the manifest.
Gudahtt
force-pushed
the
fix-non-preview-draft-prs
branch
from
9fb17b3
to
126431e
Compare
Builds ready [126431e]
Page Load Metrics (1525 ± 53 ms)
Bundle size diffs
|
NidhiKJha
approved these changes
Jul 28, 2023
brad-decker
approved these changes
Jul 28, 2023
metamaskbot
added
the
release-10.36.0
Gudahtt
added
release-11.1.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Certain draft PRs that add new dependencies have been failing because CI will try to use the GitHub npm registry, which we use for preview builds. This registry does not have non-preview package versions, so the installation will fail if new non-preview dependencies are needed.
CI has been updated to only use the GitHub npm registry when preview builds are detected in the manifest.
Manual Testing Steps
This can't be properly tested until after merging, unless you want to setup a fork with CircleCI builds. Once merged, we can test these cases:
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.