Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing PR #20096 #20103

Closed
wants to merge 2 commits into from
Closed

Testing PR #20096 #20103

wants to merge 2 commits into from

Conversation

HowardBraham
Copy link
Contributor

Draft PR to test #20096

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@HowardBraham HowardBraham force-pushed the 20096-test branch 2 times, most recently from d9a99ee to 958db88 Compare July 19, 2023 19:36
@socket-security
Copy link

socket-security bot commented Jul 19, 2023

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @metamask/auto-changelog@2.6.1

@socket-security
Copy link

socket-security bot commented Jul 19, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@HowardBraham HowardBraham force-pushed the 20096-test branch 3 times, most recently from caf233b to c52d1bd Compare July 19, 2023 19:56
Certain draft PRs that add new dependencies have been failing because
CI will try to use the GitHub npm registry, which we use for preview
builds. This registry does not have non-preview package versions, so
the installation will fail if new non-preview dependencies are needed.

CI has been updated to only use the GitHub npm registry when preview
builds are detected in the manifest.
@metamaskbot
Copy link
Collaborator

Builds ready [3197046]
Page Load Metrics (1504 ± 33 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint106194126209
domContentLoaded1380163115046833
load1380163115046833
domInteractive1380163115046833
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #20103 (3197046) into develop (39b1996) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #20103   +/-   ##
========================================
  Coverage    69.46%   69.46%           
========================================
  Files          992      992           
  Lines        37452    37452           
  Branches     10042    10042           
========================================
  Hits         26013    26013           
  Misses       11439    11439           

@HowardBraham
Copy link
Contributor Author

This was just a PR to test another PR, and that's merged now, so closing.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2023
@HowardBraham HowardBraham deleted the 20096-test branch July 31, 2023 23:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants