Commits on Oct 8, 2024

1. build: add lottie-web dependency to extension (#27632) …

   <!--
   Please submit this PR as a draft initially.
   Do not mark it as "Ready for review" until the template has been
   completely filled out, and PR status checks have passed at least once.
   -->
   
   ## **Description**
   This PR adds a new dependency, [Lottie](https://airbnb.io/lottie), to
   the extension. Lottie is an animation library.
   
   The pros:
   * Enhanced User Experience: Lottie enables us to add high-quality,
   lightweight animations that will make our extension more visually
   appealing.
   * Community Support: It is well-maintained by Airbnb and has a strong
   community behind it.
   * Consistency with Mobile App: We’re already using Lottie in mobile, so
   integrating it into the extension will provide a consistent user
   experience across platforms.
   
   With any additional dependency, we need a consider:
   * supply chain attack surface managed by lavamoat.
   * increase in bundle size – in this case < 100kB gzip-ed.
   
   [More context on
   slack](https://consensys.slack.com/archives/CTQAGKY5V/p1717772021376029).
   
   [![Open in GitHub
   Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27632?quickstart=1)
   
   ## **Related issues**
   
   * **Related:** #27650
   – use lottie animation in the extension.
   
   ## **Manual testing steps**
   
   1. Go to this page...
   2.
   3.
   
   ## **Screenshots/Recordings**
   
   <!-- If applicable, add screenshots and/or recordings to visualize the
   before and after of your change. -->
   
   ### **Before**
   
   <!-- [screenshots/recordings] -->
   
   ### **After**
   
   <!-- [screenshots/recordings] -->
   
   ## **Pre-merge author checklist**
   
   - [ ] I've followed [MetaMask Contributor
   Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
   Extension Coding
   Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
   - [ ] I've completed the PR template to the best of my ability
   - [ ] I’ve included tests if applicable
   - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
   if applicable
   - [ ] I’ve applied the right labels on the PR (see [labeling
   guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
   Not required for external contributors.
   
   ## **Pre-merge reviewer checklist**
   
   - [ ] I've manually tested the PR (e.g. pull and build branch, run the
   app, test code being changed).
   - [ ] I confirm that this PR addresses all acceptance criteria described
   in the ticket it closes and includes the necessary testing evidence such
   as recordings and or screenshots.
   
   ---------
   
   Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
   Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>

   

   3 people committed Oct 8, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for cbf6188
   • Browse repository at this point

   Copy the full SHA

   cbf6188 View commit details

   Browse the repository at this point in the history