cherry-pick – build: add lottie-web dependency to extension (#27632) into Version-v12.6.0 #27706
Conversation
dbrans
commented
Oct 8, 2024
dbrans
commented
- This PR cherry-picks build: add lottie-web dependency to extension #27632 (8dedd3c) into Version-v12.6.0.
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR adds a new dependency, [Lottie](https://airbnb.io/lottie), to the extension. Lottie is an animation library. The pros: * Enhanced User Experience: Lottie enables us to add high-quality, lightweight animations that will make our extension more visually appealing. * Community Support: It is well-maintained by Airbnb and has a strong community behind it. * Consistency with Mobile App: We’re already using Lottie in mobile, so integrating it into the extension will provide a consistent user experience across platforms. With any additional dependency, we need a consider: * supply chain attack surface managed by lavamoat. * increase in bundle size – in this case < 100kB gzip-ed. [More context on slack](https://consensys.slack.com/archives/CTQAGKY5V/p1717772021376029). [](https://codespaces.new/MetaMask/metamask-extension/pull/27632?quickstart=1) ## **Related issues** * **Related:** #27650 – use lottie animation in the extension. ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com> Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is network access?This module accesses the network. Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
Builds ready [cbf6188]
Page Load Metrics (1989 ± 95 ms)
Bundle size diffs
|
](https://codespaces.new/MetaMask/metamask-extension/pull/27632?quickstart=1){kind=link}
