Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [Snaps E2E] address snaps metrics test flaking #27519

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

bowensanders
Copy link
Contributor

@bowensanders bowensanders commented Sep 30, 2024

Description

There appears to be a test flake point very occasionally waiting for an alert popup.
This is being addressed by adding an additional delay before attempting to close the alert popup to proceed with the test.

Open in GitHub Codespaces

Related issues

Fixes: #26579

Manual testing steps

  1. Does CI Pass this test every time?

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bowensanders bowensanders added area-snaps e2e-test End to end test for the MetaMask extension flaky tests team-snaps-platform Snaps Platform team labels Sep 30, 2024
@bowensanders bowensanders self-assigned this Sep 30, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Sep 30, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [f7cfde1]
Page Load Metrics (1952 ± 69 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint31422131878382183
domContentLoaded17142193192113967
load17502214195214369
domInteractive168442199
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@bowensanders bowensanders marked this pull request as ready for review September 30, 2024 23:44
@bowensanders bowensanders requested a review from a team as a code owner September 30, 2024 23:44
@bowensanders bowensanders added this pull request to the merge queue Oct 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 4, 2024
@FrederikBolding FrederikBolding added this pull request to the merge queue Oct 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-snaps e2e-test End to end test for the MetaMask extension flaky tests team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix "Test Snap Metrics test snap update failed metric" flaky tests
4 participants