Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Test Snap Metrics test snap update failed metric" flaky tests #26579

Open
hjetpoluru opened this issue Aug 21, 2024 · 2 comments · May be fixed by #27519
Open

Fix "Test Snap Metrics test snap update failed metric" flaky tests #26579

hjetpoluru opened this issue Aug 21, 2024 · 2 comments · May be fixed by #27519
Labels
flaky tests Sev2-normal Normal severity; minor loss of service or inconvenience. team-snaps-platform Snaps Platform team type-bug

Comments

@hjetpoluru
Copy link
Contributor

hjetpoluru commented Aug 21, 2024

Latest CI link

Test scenario - Test Snap Metrics test snap update failed metric

https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/98396/workflows/be9ffb55-3ba2-4b60-9a36-92a18a5f2511/jobs/3662206/tests

TimeoutError: Waiting until element is enabled
Wait timed out after 10166ms
  (Ran on CircleCI Node 8 of 24, Job test-e2e-firefox)
    at /home/circleci/project/node_modules/selenium-webdriver/lib/webdriver.js:929:17
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/96587/workflows/b7beffde-c70c-4ee8-9f22-3d840f6e8a3f/jobs/3595672/tests

Error: listen EADDRINUSE: address already in use 127.0.0.1:8545.
  (Ran on CircleCI Node 1 of 10, Job test-e2e-firefox-flask)
    at listenSocket (webpack://Ganache/core/lib/src/server.js:193:33)
    at async Promise.allSettled (index 1)
    at Ganache.start (test/e2e/seeder/ganache.ts:23:5)
    at async withFixtures (test/e2e/helpers.js:102:7)
    at async Context.<anonymous> (test/e2e/snaps/test-snap-metrics.spec.js:802:5)
@hjetpoluru hjetpoluru added type-bug Sev2-normal Normal severity; minor loss of service or inconvenience. flaky tests team-snaps-platform Snaps Platform team labels Aug 21, 2024
@chloeYue
Copy link
Contributor

@bowensanders
Copy link
Contributor

bowensanders commented Sep 30, 2024

Note: I attempted about a hundred times to recreate this particular transient failure (locally, in VMs and in Github Codespaces). I was unsuccessful.

The failure point seemed to be waiting for an alert popup (which already had a 1 second delay before attempting to close it) which, in the CI failure above just shows a spinner at the point the alert should pop up.

#27519 adds an additional second to this delay because there does not seem to be another answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky tests Sev2-normal Normal severity; minor loss of service or inconvenience. team-snaps-platform Snaps Platform team type-bug
Projects
Status: To be fixed
Status: To be fixed
Development

Successfully merging a pull request may close this issue.

3 participants