Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed flaky test for custom screen size #27067

Merged
merged 2 commits into from
Sep 17, 2024
Merged

fix: Fixed flaky test for custom screen size #27067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
565c683
Fixed flaky test
hjetpoluru Sep 11, 2024
e4fbc69
Merge branch 'develop' into fix-flaky-test-custom-screen
hjetpoluru Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/e2e/tests/account/metamask-responsive-ui.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const FixtureBuilder = require('../../fixture-builder');

describe('MetaMask Responsive UI', function () {
it('Creating a new wallet @no-mmi', async function () {
const driverOptions = { responsive: true };
const driverOptions = { constrainWindowSize: true };

await withFixtures(
{
Expand Down Expand Up @@ -81,7 +81,7 @@ describe('MetaMask Responsive UI', function () {
});

it('Importing existing wallet from lock page', async function () {
const driverOptions = { responsive: true };
const driverOptions = { constrainWindowSize: true };

await withFixtures(
{
Expand Down Expand Up @@ -115,7 +115,7 @@ describe('MetaMask Responsive UI', function () {
});

it('Send Transaction from responsive window', async function () {
const driverOptions = { responsive: true };
const driverOptions = { constrainWindowSize: true };
await withFixtures(
{
fixtures: new FixtureBuilder().build(),
Expand Down
1 change: 0 additions & 1 deletion test/e2e/tests/swap-send/swap-send-test-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,6 @@ export const getSwapSendFixtures = (
) => {
const ETH_CONVERSION_RATE_USD = 3010;
return {
driverOptions: { responsive: true },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The window size is not mandatory for the test, so I have removed it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to confirm with the original author before we delete this. @BZahory, was there a reason that this was originally written so that the dev tools would be open during the test run (here is where your PR first added this: d0a0037#diff-f2647a24cd0065e584933d0fdc32081d6f28f75b7d1123533b91e02109d885fcR244_

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danjm Sure, I agree with you we should confirm. Just to add BZahory may not reply as he is no longer working with the Extension. I am tagging the team @MetaMask/metamask-assets here for faster confirmation and this is my observation according to the PR in the screenshot and the test scenario where the extension is just clicked and hence I am thinking the size of the window is not mandatory.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't currently see how the responsive screen size was needed, so I think it is fine to remove for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dan.

fixtures: new FixtureBuilder()
.withPreferencesController({
featureFlags: {},
Expand Down
Loading