fix: Fixed flaky test for custom screen size

[hjetpoluru]

Description

The fix for the flaky test is related to the custom screen size of the window during execution.

The flaky test was identified in multiple test scenarios with a similar pattern of false negatives in the automation tests. There were browser errors that appeared after navigating and opening the devTools, with the following error mentioned:

2024-08-22T20:14:57.507Z [driver] Called 'navigate' with arguments []

-----Received an error from Chrome-----
Request Storage.getStorageKeyForFrame failed. {"code":-32602,"message":"Frame tree node for given frame not found"}
Request Storage.getStorageKeyForFrame failed. {"code":-32602,"message":"Frame tree node for given frame not found"}
----------End of Chrome error----------

2024-08-22T20:15:04.239Z [driver] Called 'fill' with arguments ["#password","correct horse battery staple"]

And due to this error, the code mistakenly flags the test as failed and attempts to capture a screenshot, leading to Due to this error, the code mistakenly flags the test as failed and attempts to capture a screenshot, leading to another false error: NoSuchWindowError: no such window: target window already closed.

• The test specific to responive UI requires a specific window size inorder to perform correctly and with help of @danjm suggestion I have include the constrainWindowSize: true which meets the test criteria.
• Also I have noticed that the windows size is not required for the swap-send-test-utils.ts and hence removed it.

Related issues

Fixes:
#26898
#26900
#26637
#26112
#24624

Manual testing steps

Run the below commands locally or in codespaces
Webpack build
yarn
yarn build:test:webpack
yarn build:test:webpack
ENABLE_MV3=false yarn test:e2e:single test/e2e/tests/swap-send/swap-send-erc20.spec.ts --browser=chrome
ENABLE_MV3=false yarn test:e2e:single test/e2e/tests/swap-send/swap-send-eth.spec.ts --browser=chrome
ENABLE_MV3=false yarn test:e2e:single test/e2e/tests/account/metamask-responsive-ui.spec.js --browser=chrome

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.11%. Comparing base (a61b938) to head (e4fbc69).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #27067   +/-   ##
========================================
  Coverage    70.11%   70.11%           
========================================
  Files         1426     1426           
  Lines        49689    49689           
  Branches     13902    13902           
========================================
  Hits         34835    34835           
  Misses       14854    14854           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hjetpoluru]

The window size is not mandatory for the test, so I have removed it.

[danjm]

I would like to confirm with the original author before we delete this. @BZahory, was there a reason that this was originally written so that the dev tools would be open during the test run (here is where your PR first added this: d0a0037#diff-f2647a24cd0065e584933d0fdc32081d6f28f75b7d1123533b91e02109d885fcR244_

[hjetpoluru]

@danjm Sure, I agree with you we should confirm. Just to add BZahory may not reply as he is no longer working with the Extension. I am tagging the team @MetaMask/metamask-assets here for faster confirmation and this is my observation according to the PR in the screenshot and the test scenario where the extension is just clicked and hence I am thinking the size of the window is not mandatory.

[danjm]

I can't currently see how the responsive screen size was needed, so I think it is fine to remove for now.

[hjetpoluru]

Thanks Dan.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[metamaskbot]

Builds ready [e4fbc69]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1786 ± 174 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1492	2826	1788	362	174
		domContentLoaded	1444	2777	1760	365	175
		load	1481	2828	1786	363	174
		domInteractive	20	87	39	21	10

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)