-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for customizable Snap UI Input #26904
Merged
david0xd
merged 9 commits into
mrtenz/bump-snaps-packages
from
dd/snap-customizable-input
Sep 12, 2024
Merged
feat: Add support for customizable Snap UI Input #26904
david0xd
merged 9 commits into
mrtenz/bump-snaps-packages
from
dd/snap-customizable-input
Sep 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [890a0ad]
Page Load Metrics (1715 ± 62 ms)
Bundle size diffs
|
david0xd
force-pushed
the
dd/snap-customizable-input
branch
from
September 10, 2024 12:59
890a0ad
to
dc2adab
Compare
david0xd
changed the base branch from
develop
to
mrtenz/bump-snaps-packages
September 11, 2024 10:23
Quality Gate failedFailed conditions |
david0xd
force-pushed
the
dd/snap-customizable-input
branch
from
September 11, 2024 10:31
ee1a240
to
dd51709
Compare
david0xd
force-pushed
the
dd/snap-customizable-input
branch
from
September 11, 2024 12:08
dd51709
to
48a96e4
Compare
david0xd
force-pushed
the
dd/snap-customizable-input
branch
from
September 11, 2024 12:19
48a96e4
to
5facad4
Compare
## **Description** Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? Adding in the `section` snaps component. 2. What is the improvement/solution? Allows developers to group their components in sections to provide a richer UI. ## **Related issues** Fixes: MetaMask/MetaMask-planning#3068 ## **Screenshots/Recordings** ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
david0xd
force-pushed
the
dd/snap-customizable-input
branch
from
September 11, 2024 12:56
5facad4
to
12fd50c
Compare
Mrtenz
force-pushed
the
mrtenz/bump-snaps-packages
branch
from
September 11, 2024 13:11
98674cd
to
ba235fc
Compare
GuillaumeRx
approved these changes
Sep 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds changes required to enable customizable Input component for Snaps custom UI.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3067
Manual testing steps
Screenshots/Recordings
Before
Input with additional elements other than button was not supported before (nothing significant to show here).
After
Pre-merge author checklist
Pre-merge reviewer checklist