Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for customizable Snap UI Input #26904

Merged
merged 9 commits into from
Sep 12, 2024

Conversation

david0xd
Copy link
Contributor

@david0xd david0xd commented Sep 4, 2024

Description

This PR adds changes required to enable customizable Input component for Snaps custom UI.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3067

Manual testing steps

  1. Install Snap with custom UI which has customized input with all combinations of start and end accessories.

Screenshots/Recordings

Before

Input with additional elements other than button was not supported before (nothing significant to show here).

After

Screenshot 2024-09-11 at 16 55 08

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@david0xd david0xd added the team-snaps-platform Snaps Platform team label Sep 4, 2024
@david0xd david0xd self-assigned this Sep 4, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [890a0ad]
Page Load Metrics (1715 ± 62 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15572192171812660
domContentLoaded15172079168910852
load15602211171512862
domInteractive17187534723
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 428 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@david0xd david0xd changed the base branch from develop to mrtenz/bump-snaps-packages September 11, 2024 10:23
Copy link

sonarcloud bot commented Sep 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

hmalik88 and others added 3 commits September 11, 2024 14:51
## **Description**


Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change? Adding in the `section` snaps
component.
2. What is the improvement/solution? Allows developers to group their
components in sections to provide a richer UI.


## **Related issues**

Fixes: MetaMask/MetaMask-planning#3068

## **Screenshots/Recordings**



## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@david0xd david0xd marked this pull request as ready for review September 11, 2024 15:31
@david0xd david0xd requested a review from a team as a code owner September 11, 2024 15:31
@david0xd david0xd merged commit c2ed776 into mrtenz/bump-snaps-packages Sep 12, 2024
65 of 70 checks passed
@david0xd david0xd deleted the dd/snap-customizable-input branch September 12, 2024 12:02
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants