Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add section component #26718

Merged
merged 5 commits into from
Sep 11, 2024
Merged

Conversation

hmalik88
Copy link
Contributor

@hmalik88 hmalik88 commented Aug 28, 2024

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:

  1. What is the reason for the change? Adding in the section snaps component.
  2. What is the improvement/solution? Allows developers to group their components in sections to provide a richer UI.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3068

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-snaps-platform Snaps Platform team label Aug 28, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Aug 28, 2024
@hmalik88 hmalik88 marked this pull request as ready for review September 10, 2024 00:43
@hmalik88 hmalik88 requested a review from a team as a code owner September 10, 2024 00:43
Copy link

sonarcloud bot commented Sep 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@hmalik88
Copy link
Contributor Author

Waiting for new snaps package release for the SectionElement

@GuillaumeRx GuillaumeRx changed the base branch from develop to mrtenz/bump-snaps-packages September 11, 2024 12:43
@Mrtenz Mrtenz merged commit 27ecdb9 into mrtenz/bump-snaps-packages Sep 11, 2024
33 of 49 checks passed
@Mrtenz Mrtenz deleted the hm/add-section-component branch September 11, 2024 12:51
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants