Skip to content

Conversation

@NidhiKJha
Copy link
Member

@NidhiKJha NidhiKJha commented Apr 3, 2024

This PR is to ensure that the correct connected accounts show up when you visit the connections page via the permissions page

Related issues

Fixes: MetaMask-planning/issues/2282

Manual testing steps

  1. Go to permissions page
  2. check the permission page redirect you to connection page correctly

Screenshots/Recordings

Before

Screen.Recording.2024-03-28.at.3.25.16.PM.mov

After

Screen.Recording.2024-04-09.at.6.46.46.PM.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NidhiKJha NidhiKJha added DO-NOT-MERGE Pull requests that should not be merged team-core-extension-ux Core Extension UX team labels Apr 3, 2024
@NidhiKJha NidhiKJha marked this pull request as ready for review April 9, 2024 13:07
@NidhiKJha NidhiKJha requested a review from a team as a code owner April 9, 2024 13:07
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Apr 9, 2024
@NidhiKJha NidhiKJha added needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. and removed DO-NOT-MERGE Pull requests that should not be merged labels Apr 9, 2024
@NidhiKJha NidhiKJha changed the title WIP: added connections logic specific to dapp fix: Added connections logic specific to dapp Apr 9, 2024
@NidhiKJha NidhiKJha force-pushed the connection-to-permission-fix branch from b81c320 to 0f8cde5 Compare April 9, 2024 15:05
@darkwing
Copy link
Contributor

darkwing commented Apr 9, 2024

This doesn't appear to be working as expected -- no accounts are listed:

Screen.Recording.2024-04-09.at.5.01.38.PM.mov

@darkwing
Copy link
Contributor

darkwing commented Apr 9, 2024

After this is fixed, we need to pick up #23789

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 48.64865% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 67.54%. Comparing base (c0e3ca0) to head (52a13a2).

Files Patch % Lines
ui/selectors/permissions.js 43.33% 17 Missing ⚠️
ui/components/multichain/app-header/app-header.js 0.00% 1 Missing ⚠️
...tichain/pages/permissions-page/permissions-page.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #23844      +/-   ##
===========================================
+ Coverage    67.53%   67.54%   +0.01%     
===========================================
  Files         1245     1245              
  Lines        48848    48864      +16     
  Branches     12743    12744       +1     
===========================================
+ Hits         32989    33003      +14     
- Misses       15859    15861       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [52a13a2]
Page Load Metrics (898 ± 539 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint603611438440
domContentLoaded99429199
load4829918981123539
domInteractive99429199
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: -211 Bytes (-0.00%)
  • common: 543 Bytes (0.01%)

@@ -41,9 +41,7 @@ exports[`Connections Content should render correctly 1`] = `
/>
<span
class="mm-box mm-text mm-text--heading-md mm-text--ellipsis mm-text--text-align-center mm-box--color-text-default"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we retain this empty span?

@NidhiKJha NidhiKJha merged commit d15cc54 into develop Apr 12, 2024
@NidhiKJha NidhiKJha deleted the connection-to-permission-fix branch April 12, 2024 10:54
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2024
@metamaskbot metamaskbot added the release-11.15.0 Issue or pull request that will be included in release 11.15.0 label Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-11.15.0 Issue or pull request that will be included in release 11.15.0 team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants