-
Notifications
You must be signed in to change notification settings - Fork 5.5k
fix: Added connections logic specific to dapp #23844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b81c320 to
0f8cde5
Compare
|
This doesn't appear to be working as expected -- no accounts are listed: Screen.Recording.2024-04-09.at.5.01.38.PM.mov |
|
After this is fixed, we need to pick up #23789 |
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #23844 +/- ##
===========================================
+ Coverage 67.53% 67.54% +0.01%
===========================================
Files 1245 1245
Lines 48848 48864 +16
Branches 12743 12744 +1
===========================================
+ Hits 32989 33003 +14
- Misses 15859 15861 +2 ☔ View full report in Codecov by Sentry. |
Builds ready [52a13a2]
Page Load Metrics (898 ± 539 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
| @@ -41,9 +41,7 @@ exports[`Connections Content should render correctly 1`] = ` | |||
| /> | |||
| <span | |||
| class="mm-box mm-text mm-text--heading-md mm-text--ellipsis mm-text--text-align-center mm-box--color-text-default" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we retain this empty span?
This PR is to ensure that the correct connected accounts show up when you visit the connections page via the permissions page
Related issues
Fixes: MetaMask-planning/issues/2282
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2024-03-28.at.3.25.16.PM.mov
After
Screen.Recording.2024-04-09.at.6.46.46.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist