fix: UX: Multichain: Remove 'Connected Sites' global item when in MC #23789
+154
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkwing
added
team-core-extension-ux
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
7 tasks
NidhiKJha
previously approved these changes
Apr 15, 2024
7 tasks
vthomas13
previously approved these changes
Apr 15, 2024
NidhiKJha
added a commit
that referenced
this pull request
Apr 16, 2024
…24023) This PR is to fix the UI bugs in the wallet, permissions and connections screen to keep it in sync with the Updated designs ## **Description** Following changes are updated: 1. Description of the product tour for global menu [Note: This product tour will be removed] 2. Remove Connected dApp shown on Account List Item 3. Remove Connect account action in Select Account Modal ## **Related issues** Fixes: #23858 ## **Manual testing steps** This PR solves Part of the linked issue, rest of them are already resolved via different other PRs, Linking them in the list: 1. Description of the product tour for global menu - Modified in this PR 2. Connected sites and All Permissions in Global menu - [23789](#23789) 3. Remove Connected dApp shown on Account List Item - Modified in this PR 4. Connected Account Toast should only be displayed on Wallet screen - [23733](#23733) 5. Remove Connect account action in Select Account Modal - Modified in this PR 6. Network switching within Extension - This isssue doesn't exist anymore. 7. Button in Network switch Modal - Was related to Design System, fixed. ## **Screenshots/Recordings** ### **Before** Please refer to the issue ### **After** 1. This Product tour will be removed in a separate PR 2. No dapp logo on account list item even when it's connected  3. No connect button in account list item menu  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: David Walsh <davidwalsh83@gmail.com>
… mc-remove-connected-sites-global-item
Collaborator
Builds ready [9795555]
Page Load Metrics (1596 ± 661 ms)
Bundle size diffs
|
NidhiKJha
previously approved these changes
Apr 24, 2024
darkwing
added
the
amon-hen-v1
salimtb
reviewed
May 6, 2024
| await driver.clickElement('[data-testid="global-menu-connected-sites"]'); | ||
| await driver.findElement({ | ||
| text: 'Account 1 is not connected to any sites.', | ||
| tag: 'p', |
Contributor
There was a problem hiding this comment.
I recommend avoiding large if-else structures as they can make the code cumbersome. Instead, consider dividing the logic into two distinct functions: disconnectFromTestDappMultichain and disconnectFromTestDapp. By defining these functions separately and calling them directly where needed, we can streamline the code, enhancing its readability and ease of maintenance.
Contributor
Author
|
Superceded by Nidhi's PR to remove the feature flag. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During QA @sleepytanya was getting tripped up by this legacy "Connected Sites" global menu item. It should no longer be there once we ship Multichain, so I'm hiding it when the flag is on
Related issues
Fixes: N/A
Manual testing steps
MULTICHAIN=1flagScreenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Pre-merge reviewer checklist