fix: smart swaps missing chain ID

[matthewwalsh0]

Description

Fix hanging smart swaps by including chainId parameter in unsigned transactions when signing.

This is now required by the multi-chain support in TransactionController.

Related issues

Fixes: #23373

Manual testing steps

See issue.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[metamaskbot]

Builds ready [928bf5a]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1382 ± 499 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	75	253	154	44	21
		domContentLoaded	11	115	40	25	12
		load	59	2445	1382	1040	499
		domInteractive	11	115	40	25	12

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 24 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 68.71%. Comparing base (171b6c7) to head (928bf5a).
Report is 2 commits behind head on develop.

Files	Patch %	Lines
ui/ducks/swaps/swaps.js	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #23425      +/-   ##
===========================================
- Coverage    68.72%   68.71%   -0.00%     
===========================================
  Files         1122     1122              
  Lines        43577    43579       +2     
  Branches     11661    11661              
===========================================
  Hits         29945    29945              
- Misses       13632    13634       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Missing release label release-11.12.0 on PR. Adding release label release-11.12.0 on PR and removing other release labels(release-11.14.0), as PR was cherry-picked in branch 11.12.0.