Skip to content

[Bug]: Swap is no longer working when Smart Transaction is turned ON #23373

@davibroc

Description

@davibroc

Describe the bug

When Smart Transaction is turned ON, Swap is no longer working

From the initial look
TransactionController.approveTransactionsWithSameNonce expects a chainId inside each transaction, which is missing now. It can be added to transactions in ui/ducks/swaps/swaps.js in the

The problem doesn't happen if Smart Transaction is OFF or in production

Expected behavior

Swap is able complete when Smart Transcation is ON

Screenshots/Recordings

Swap_STX.mov

image (8)

Steps to reproduce

  1. Go to Swap
  2. Turn Smart Transaction ON
  3. Get a quote ETH->WETH
  4. Click on Swap
  5. Notice that the screen gets stuck on Preparing Swap

Error messages or log output

signAndSendSwapsSmartTransaction error (Error#1)

The number NaN cannot be converted to a BigInt because it is not an integer

Version

develop

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

Metadata

Metadata

Assignees

Labels

regression-RCDEPRECATED: Please use "regresssion-RC-x.y.z" label insteadregression-RC-11.12.0release-11.12.0Issue or pull request that will be included in release 11.12.0release-11.14.0Issue or pull request that will be included in release 11.14.0release-blockerThis bug is blocking the next releaseteam-confirmations-system-deprecatedDEPRECATED: please use "team-confirmations" insteadtype-bugSomething isn't working

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions