fix: update Nft metadata when toggles are on #23293

sahar-fehri · 2024-03-04T12:49:09Z

Description

Fetches NFT metadata when IPFS toggle or Display media toggle are on

Related issues

Core PR: MetaMask/core#4008

Manual testing steps

Go to settings and disable IPFS toggle and disable display Media toggle
Import an NFT (where metadata is hosted on IPFS)
Enable IPFS toggle
You should see the image on the home page
Import an NFT where NFT metadata are hosted on https server
Go to settings and enable the display media toggle
You should see the NFT metadata on home page

Screenshots/Recordings

Before

Screen.Recording.2024-03-04.at.14.31.31.mov

After

videoAfter.mov

Pre-merge author checklist

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-03-04T12:49:23Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

sahar-fehri · 2024-03-04T14:48:53Z

update-policies

sahar-fehri · 2024-03-04T15:50:02Z

.yarn/patches/@metamask-assets-controllers-patch-74191f09e4.patch

+     * @param networkClientId - The networkClientId that can be used to identify the network client to use for this request.
+     * @param userAddress - The current user address
+     */
+    updateNftMetadata(nfts, networkClientId, userAddress = this.config.selectedAddress) {


Here are the steps how this file was generated:
1- Updated node-modules NftController.js (by adding my new fct)
2- yarn patch @metamask/assets-controllers --update
3- I updated the nftController.js file under /private/var/folders/j2/z5v3y5wd23z_9ldp7tkknszh0000gn/T/xfs-6b6a5943/user
4- yarn patch-commit -s /private/var/folders/j2/z5v3y5wd23z_9ldp7tkknszh0000gn/T/xfs-6b6a5943/user

metamaskbot · 2024-03-04T15:54:18Z

Builds ready [82fab54]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1405 ± 270 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	68	173	116	21	10
		domContentLoaded	9	78	26	19	9
		load	92	1851	1405	563	270
		domInteractive	9	77	26	19	9

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 46 Bytes (0.00%)
ui: 775 Bytes (0.01%)
common: 527 Bytes (0.01%)

codecov · 2024-03-04T15:54:25Z

Codecov Report

Attention: Patch coverage is 60.71429% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 68.63%. Comparing base (ffd58dd) to head (c563892).

❗ Current head c563892 differs from pull request most recent head 9f2a51e. Consider uploading reports for the commit 9f2a51e to get more accurate results

Files	Patch %	Lines
ui/components/app/nfts-tab/nfts-tab.js	40.00%	9 Missing ⚠️
ui/store/actions.ts	84.62%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #23293      +/-   ##
===========================================
+ Coverage    68.45%   68.63%   +0.19%     
===========================================
  Files         1141     1099      -42     
  Lines        43769    43387     -382     
  Branches     11729    11593     -136     
===========================================
- Hits         29958    29778     -180     
+ Misses       13811    13609     -202

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-03-04T19:11:41Z

Builds ready [c563892]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1047 ± 382 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	62	238	121	39	19
		domContentLoaded	9	78	34	24	11
		load	58	1874	1047	795	382
		domInteractive	9	78	34	24	11

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 46 Bytes (0.00%)
ui: 798 Bytes (0.01%)
common: 548 Bytes (0.01%)

ui/components/app/nfts-tab/nfts-tab.js

socket-security · 2024-03-18T16:58:16Z

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

This reverts commit b1cdfbe.

sahar-fehri · 2024-03-18T17:33:48Z

closing this in favor of this #23558

sahar-fehri requested a review from a team as a code owner March 4, 2024 12:49

sahar-fehri marked this pull request as draft March 4, 2024 12:49

sahar-fehri mentioned this pull request Mar 4, 2024

fix: add updateNft fct MetaMask/core#4008

Merged

3 tasks

sahar-fehri added team-core-extension-ux Core Extension UX team team-assets labels Mar 4, 2024

sahar-fehri marked this pull request as ready for review March 4, 2024 15:18

sahar-fehri self-assigned this Mar 4, 2024

sahar-fehri commented Mar 4, 2024

View reviewed changes

DDDDDanica reviewed Mar 5, 2024

View reviewed changes

ui/components/app/nfts-tab/nfts-tab.js Outdated Show resolved Hide resolved

sahar-fehri force-pushed the fix/fix-import-nft-when-toggle-off branch from c563892 to 590eb72 Compare March 18, 2024 16:54

sahar-fehri added 5 commits March 18, 2024 18:01

fix: update Nft metadata when toggles are on

685cbe9

fix: add patch

e4994ab

fix: add unit test for action

b2f81d5

Revert "fix: add patch"

986a057

This reverts commit b1cdfbe.

fix: update patch and fix actions

a6565a3

sahar-fehri force-pushed the fix/fix-import-nft-when-toggle-off branch from c38fe3e to 5e4bc8c Compare March 18, 2024 17:01

fix: refactor

9f2a51e

sahar-fehri force-pushed the fix/fix-import-nft-when-toggle-off branch from 5e4bc8c to 9f2a51e Compare March 18, 2024 17:04

sahar-fehri closed this Mar 18, 2024

github-actions bot locked and limited conversation to collaborators Mar 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: update Nft metadata when toggles are on #23293

fix: update Nft metadata when toggles are on #23293

sahar-fehri commented Mar 4, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Mar 4, 2024

Uh oh!

sahar-fehri commented Mar 4, 2024

Uh oh!

sahar-fehri Mar 4, 2024

Uh oh!

metamaskbot commented Mar 4, 2024

Uh oh!

codecov bot commented Mar 4, 2024 •

edited

Loading

Uh oh!

metamaskbot commented Mar 4, 2024

Uh oh!

Uh oh!

socket-security bot commented Mar 18, 2024 •

edited

Loading

Uh oh!

sahar-fehri commented Mar 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix: update Nft metadata when toggles are on #23293

fix: update Nft metadata when toggles are on #23293

Conversation

sahar-fehri commented Mar 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Mar 4, 2024

Uh oh!

sahar-fehri commented Mar 4, 2024

Uh oh!

sahar-fehri Mar 4, 2024

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Mar 4, 2024

Uh oh!

codecov bot commented Mar 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

metamaskbot commented Mar 4, 2024

Uh oh!

Uh oh!

socket-security bot commented Mar 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sahar-fehri commented Mar 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sahar-fehri commented Mar 4, 2024 •

edited

Loading

codecov bot commented Mar 4, 2024 •

edited

Loading

socket-security bot commented Mar 18, 2024 •

edited

Loading