fix: refactor

Author: sahar-fehri

.yarn/patches/@metamask-assets-controllers-patch-74191f09e4.patch

@@ -245,11 +245,7 @@
     "@metamask/address-book-controller": "^3.0.0",
     "@metamask/announcement-controller": "^5.0.1",
     "@metamask/approval-controller": "^5.1.2",
-<<<<<<< HEAD
     "@metamask/assets-controllers": "^26.0.0",
-=======
-    "@metamask/assets-controllers": "patch:@metamask/assets-controllers@patch%3A@metamask/assets-controllers@npm%253A24.0.0%23~/.yarn/patches/@metamask-assets-controllers-npm-24.0.0-dfef136464.patch%3A%3Aversion=24.0.0&hash=f321cb#~/.yarn/patches/@metamask-assets-controllers-patch-74191f09e4.patch",
->>>>>>> c563892848 (fix: update patch and fix actions)
     "@metamask/base-controller": "^4.1.0",
     "@metamask/browser-passworder": "^4.3.0",
     "@metamask/contract-metadata": "^2.3.1",

package.json

@@ -77,12 +77,9 @@ export default function NftsTab() {
       (isIpfsEnabled || openSeaEnabled) &&
       (hasAnyNfts || hasAnyPreviouslyOwnedNfts)
     ) {
-      const allNfts = [...previouslyOwnedCollection.nfts];
-      for (const key in collections) {
-        if (Object.hasOwn(collections, key)) {
-          allNfts.push(...collections[key].nfts);
-        }
-      }
+      const allNfts = previouslyOwnedCollection.nfts.concat(
+        Object.values(collections).flatMap((collection) => collection.nfts),
+      );
       const nftsToUpdateMetadata = allNfts.filter(
         (singleNft) =>
           !singleNft.name && !singleNft.description && !singleNft.image,

ui/components/app/nfts-tab/nfts-tab.js

@@ -3942,42 +3942,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@metamask/assets-controllers@patch:@metamask/assets-controllers@patch%3A@metamask/assets-controllers@npm%253A24.0.0%23~/.yarn/patches/@metamask-assets-controllers-npm-24.0.0-dfef136464.patch%3A%3Aversion=24.0.0&hash=f321cb#~/.yarn/patches/@metamask-assets-controllers-patch-74191f09e4.patch":
-  version: 24.0.0
-  resolution: "@metamask/assets-controllers@patch:@metamask/assets-controllers@patch%3A@metamask/assets-controllers@npm%253A24.0.0%23~/.yarn/patches/@metamask-assets-controllers-npm-24.0.0-dfef136464.patch%3A%3Aversion=24.0.0&hash=f321cb#~/.yarn/patches/@metamask-assets-controllers-patch-74191f09e4.patch::version=24.0.0&hash=f31c74"
-  dependencies:
-    "@ethersproject/address": "npm:^5.7.0"
-    "@ethersproject/bignumber": "npm:^5.7.0"
-    "@ethersproject/contracts": "npm:^5.7.0"
-    "@ethersproject/providers": "npm:^5.7.0"
-    "@metamask/abi-utils": "npm:^2.0.2"
-    "@metamask/approval-controller": "npm:^5.1.1"
-    "@metamask/base-controller": "npm:^4.0.1"
-    "@metamask/contract-metadata": "npm:^2.4.0"
-    "@metamask/controller-utils": "npm:^8.0.1"
-    "@metamask/eth-query": "npm:^4.0.0"
-    "@metamask/metamask-eth-abis": "npm:3.0.0"
-    "@metamask/network-controller": "npm:^17.1.0"
-    "@metamask/polling-controller": "npm:^4.0.0"
-    "@metamask/preferences-controller": "npm:^6.0.0"
-    "@metamask/rpc-errors": "npm:^6.1.0"
-    "@metamask/utils": "npm:^8.2.0"
-    "@types/uuid": "npm:^8.3.0"
-    async-mutex: "npm:^0.2.6"
-    cockatiel: "npm:^3.1.2"
-    ethereumjs-util: "npm:^7.0.10"
-    lodash: "npm:^4.17.21"
-    multiformats: "npm:^9.5.2"
-    single-call-balance-checker-abi: "npm:^1.0.0"
-    uuid: "npm:^8.3.2"
-  peerDependencies:
-    "@metamask/approval-controller": ^5.1.1
-    "@metamask/network-controller": ^17.1.0
-    "@metamask/preferences-controller": ^6.0.0
-  checksum: b68114d44eb90e6c4799d75b1eda2f2b707010be9250205136c20d3ef9086801c9d1292589c4e82c7209262358d31707f4432ad8970161896011f62fd29c9e42
-  languageName: node
-  linkType: hard
-
 "@metamask/auto-changelog@npm:^2.1.0":
   version: 2.6.1
   resolution: "@metamask/auto-changelog@npm:2.6.1"
@@ -36085,4 +36049,4 @@ __metadata:
   resolution: "zxcvbn@patch:zxcvbn@npm%3A4.4.2#./.yarn/patches/zxcvbn-npm-4.4.2-6527983856.patch::version=4.4.2&hash=e3565a&locator=metamask-crx%40workspace%3A."
   checksum: 4413b5c71428a92b08fa11ef238987609af399447f33a76b6aa66ab2f964c88037a3d7692bf3d644bc68dd386e4ebe0476bae041fe6b515963f497879c04fbff
   languageName: node
-  linkType: hard
+  linkType: hard