Skip to content

Conversation

@ardier16
Copy link

@ardier16 ardier16 commented Feb 21, 2024

Description

According to ethereum-lists/chains#4389 Q Mainnet symbol is changed from "Q" to "QGOV". This change is not reflected in MetaMask and the users see the scam badge on their Q Mainnet balance.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to https://chainid.network/
  2. Search for 35441 (Q Mainnet chain ID)
  3. Add network to MetaMask
  4. Switch to Q Mainnet network in MetaMask
  5. Notice the scam warning in asset list

Screenshots/Recordings

Screenshot 2024-02-21 at 18 58 42 Screenshot 2024-02-21 at 18 58 48

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@ardier16 ardier16 requested a review from a team as a code owner February 21, 2024 17:02
@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added external-contributor INVALID-PR-TEMPLATE PR's body doesn't match template labels Feb 21, 2024
@ardier16
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@metamaskbot metamaskbot removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Feb 22, 2024
@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Apr 26, 2024
@github-actions
Copy link
Contributor

This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions.

@github-actions github-actions bot closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-contributor stale issues and PRs marked as stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants