chore: Update @metamask/signature-controller and related packages
#22861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package `@metamask/signature-controller` has been updated from v6 to v12. Despite the large number of major version bumps, no code changes were required. All breaking changes were due to changes in peer dependencies, and to type changes. The package `@metamask/approval-controller` needed a patch bump to satisfy the peer dependency requirements of `@metamask-signature-controller`, and `@metamask/logging-controller` needed a major bump for the same reason. The only `LoggingController` breaking change was to the types, so again no changes required. Here are all of the changelogs for these bumps: * https://github.com/MetaMask/core/blob/main/packages/signature-controller/CHANGELOG.md * https://github.com/MetaMask/core/blob/main/packages/logging-controller/CHANGELOG.md#202 * https://github.com/MetaMask/core/blob/main/packages/approval-controller/CHANGELOG.md#512
Member
Author
|
@metamaskbot update-policies |
Collaborator
|
Policies updated |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #22861 +/- ##
===========================================
- Coverage 68.48% 68.47% -0.01%
===========================================
Files 1088 1088
Lines 42897 42902 +5
Branches 11425 11424 -1
===========================================
- Hits 29378 29377 -1
- Misses 13519 13525 +6 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [3a91e24]
Page Load Metrics (756 ± 19 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
legobeat
approved these changes
Feb 7, 2024
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/logging-controller@1.0.4, npm/@metamask/signature-controller@6.1.3 |
Collaborator
Builds ready [a96d5c8]
Page Load Metrics (773 ± 28 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
13 tasks
darkwing
approved these changes
Feb 8, 2024
brad-decker
approved these changes
Feb 8, 2024
Collaborator
Builds ready [0b313e3]
Page Load Metrics (758 ± 18 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
metamaskbot
added
the
release-11.12.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The package
@metamask/signature-controllerhas been updated from v6 to v12. Despite the large number of major version bumps, no code changes were required. All breaking changes were due to changes in peer dependencies, and to type changes.The package
@metamask/approval-controllerneeded a patch bump to satisfy the peer dependency requirements of@metamask-signature-controller, and@metamask/logging-controllerneeded a major bump for the same reason. The onlyLoggingControllerbreaking change was to the types, so again no changes required.Here are all of the changelogs for these bumps:
Related issues
N/A
Manual testing steps
N/A
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist